feat: departments controllers #75
Open
+244
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czaja307
reviewed
Jan 9, 2025
| gradientStart: "red", | ||
| gradientStop: "blue", | ||
| }); | ||
| await Department.createMany([ |
There was a problem hiding this comment.
it's nice that you added such realistic data :D
mini-bomba
requested changes
Jan 17, 2025
Comment on lines
10
to
15
| async index({ request }: HttpContext) { | ||
| const { page, limit } = await request.validateUsing(paginationValidator); | ||
| const baseQuery = FieldsOfStudy.query().withScopes((scopes) => { | ||
| scopes.preloadRelations(request.only(this.relations)); | ||
| scopes.handleSortQuery(request.input("sort")); | ||
| }); |
There was a problem hiding this comment.
The scope for searching is missing.
mini-bomba
reviewed
Jan 19, 2025
app/models/department_link.ts
Outdated
There was a problem hiding this comment.
you can now revert the changes mage to this file
Comment on lines
12
to
18
| const baseQuery = FieldsOfStudy.query().withScopes((scopes) => { | ||
| scopes.handleSearchQuery( | ||
| request.only(["id", "name", "createdAt", "updatedAt"]), | ||
| ); | ||
| scopes.preloadRelations(request.only(this.relations)); | ||
| scopes.handleSortQuery(request.input("sort")); | ||
| }); |
There was a problem hiding this comment.
why are we excluding so many fields that are potentially useful to filter by?
IMO only the url should not be searchable.
Suggested change
| const baseQuery = FieldsOfStudy.query().withScopes((scopes) => { | |
| scopes.handleSearchQuery( | |
| request.only(["id", "name", "createdAt", "updatedAt"]), | |
| ); | |
| scopes.preloadRelations(request.only(this.relations)); | |
| scopes.handleSortQuery(request.input("sort")); | |
| }); | |
| const baseQuery = FieldsOfStudy.query().withScopes((scopes) => { | |
| scopes.handleSearchQuery(request.qs(), "url"); | |
| scopes.preloadRelations(request.only(this.relations)); | |
| scopes.handleSortQuery(request.input("sort")); | |
| }); |
Comment on lines
13
to
20
| scopes.handleSearchQuery( | ||
| request.except([ | ||
| "logo", | ||
| "description", | ||
| "gradientStart", | ||
| "gradientStop", | ||
| ]), | ||
| ); |
There was a problem hiding this comment.
Suggested change
| scopes.handleSearchQuery( | |
| request.except([ | |
| "logo", | |
| "description", | |
| "gradientStart", | |
| "gradientStop", | |
| ]), | |
| ); | |
| scopes.handleSearchQuery( | |
| request.qs(), | |
| "logo", | |
| "description", | |
| "gradientStart", | |
| "gradientStop", | |
| ); |
+ prettier cuz i typed this out by hand
mini-bomba
changed the title
…epartment_link model changes
czaja307
requested changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.