Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(fileService): improve error handling #96

Open
czaja307 opened this issue Jan 23, 2025 · 0 comments
Open

refactor(fileService): improve error handling #96

czaja307 opened this issue Jan 23, 2025 · 0 comments

Comments

@czaja307
Copy link
Member

I really dislike how this fileService works, with it returning an error instead of just throwing.

Also the error should probably be rethrown, since it's a critical error anyway.

and of course it throws when I try to use it, looks like it doesn't try to create the storage dir if it doesn't exist
image

Originally posted by @mini-bomba in #87 (comment)

@czaja307 czaja307 changed the title I really dislike how this fileService works, with it returning an error instead of just throwing. refactor(fileService): improve error handling Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant