-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compatibility with SonarQube 6.0 #9
Comments
We are using SonarQube 6.0 and this plugin. It didn't work; see error message below. Not sure if the problem is in this plugin or in SonarQube. This is our SonarQube log (TRACE level): TRACE web[sql] time=0ms | sql=SELECT t.* FROM (SELECT ROW_NUMBER() OVER(ORDER BY [groups].id) AS _row_num, * FROM [groups] WHERE ([groups].[name] = N'...')) AS t WHERE t._row_num BETWEEN 1 AND 1 |
I have the same problem after upgradring to SonarQube 6.0, any news when this will be fixed? |
We have the same problem after upgrading to SonarQube 6.0. Login via Browser or TFS Build Agent (Sonarubq Endpoint) no longer works. This is our SonarQube Log File:
|
Same issue here. |
Same problem here. |
Hi guys, I've created this ticket because this plugin is no more compatible with SonarQube 6.0, so you don't need to add comments to say it's not working ! As you all seems to use it, maybe one of you could could become the lead developer of it ? Regards |
@julienlancelot it's disappointing that this was portrayed as an officially supported product by the fact of being in the LDAP plugin. Then the decision was made to separate it out which I supported, but I didn't realize it was community supported. It's pretty sad considering all the work that's being done to support the Microsoft platform in general that it's official authentication mechanism is left out to dry. Also, I believe the sonarsource team did the surgery to separate out this plugin. Why would they build it on a platform that they knew was going away? (You guys have been killing RoR for many versions now.) |
@jabbera This plugin is only about using Active Directory as SSO. The sonar-ldap is still supporting Active Directory feature (search for Active Directory in the documentation). |
@julienlancelot and @hamenon: It would have been nice if there had been a clear warning of Breaking Changes in the Release 6.0. Working without SSO is not an option if you are used to the workflow in conjunction with the Team Foundation Server for our Product Manager. |
I apologize in advance if I should be opening a Support case... just thought I'd start here with an interested group. In SonarQube 5.6, I was using the AD SSO plugin; was very simple and worked great. Upgrade to 6.0 broke it. I have been unable to get the LDAP plugin (2.0) working in SonarQube 5.6.1 or 6.0. Looks like some AD functionality was ripped out of the LDAP plugin. I have partial success with the 1.5.1 version of the LDAP plugin - users have to log in with fully qualified name (user@company), but it works, with only these lines of config: Does anyone have any tips for getting this working in LDAP plugin 2.0? Seems like an LDAP bind is always required, and I can't get that to succeed (though I'm using settings that are working fine in another product... (ahem) Coverity...). Thanks for any insight you can share! |
@jkleppinger You must write to the SonarQube Google group. |
Just want to confirm - this is no longer supported. Or its community supported with no one actively working on it? My own upgrade just went south with the collation issue & if this isn't being actively supported by the community I need to revert back to an older version |
My understanding is this is now a community plugin that is unsupported with no maintainer. Even once the issue is fixed by removing the ruby code, SSO will not be possible. Users will have to click a link at the bottom of the login page. To get SSO back I think we will need: https://jira.sonarsource.com/browse/SONAR-5430?jql=text%20~%20%22Http%20header%22 (Notice this feature has been pushed every version since early 5 series. It's never made the cut) We can then put IIS in front of sonar and be done with it. (I do this already for SSL so it's a small change for me thankfully) |
@jabbera Indeed this plugin is now under the community umbrella. |
@julienlancelot that would be a good solution, like @jabbera we too are using IIS in front of SonarQube. |
I can't believe that https://jira.sonarsource.com/browse/SONAR-5430 was pushed to 6.2 and now the AD plugin is totally broken with 6.1-RC1. You've taken a product that was highly accessible to windows users and slowly destroyed the experience. 2016.09.22 08:13:44 ERROR web[][o.s.s.p.w.RootFilter] Processing of request /sessions/new?return_to=%2F failed |
Hi Mike, First thing, as this plugin was already not working in SonarQube 6.0, I don't see how it would have magically work in 6.1.... And just to be clear for every one : SONAR-5430 will make possible to use Active Directory by using a SSO, but this plugin will still not be usable, unless someone is taking the lead to fix it. |
It does work in 6.0, just not the way one would expect. I'm able to login manually by using mbarry@blah. That is what no longer works in 6.1. I totally understand the 5430 has nothing to do with this plugin working. I'll be more then happy to publish the code required to get SSO working with IIS once 5430 is available. Mike |
I can also confirm that was working with 6.0 an now not any longer. Johannes |
I've gone back to the LDAP plugin. Removed the @Domain from tables: users, groups, and user_tokens. Fixed casing of groups. |
I've almost got my https://github.com/trajano/reverse-proxy-auth-sonar-plugin working with V6.1 (I presume it will still work with V6.0). There I have an SSO like implementation when the realm is enabled. |
FYI https://jira.sonarsource.com/browse/SONAR-5430 is "almost" done, it's on the latest build of SonarQube (https://github.com/SonarSource/sonarqube). |
Cool then I can discontinue development of my plugin as soon as this is released. trajano.net On Fri, Oct 28, 2016 at 12:09 PM -0400, "Julien Lancelot" [email protected] wrote: FYI https://jira.sonarsource.com/browse/SONAR-5430 is "almost" done, it's on the latest build of SonarQube (https://github.com/SonarSource/sonarqube). If someone wants to have a try (building from sources), it would be great ! — |
While I don't have it in me to compile a non RC of sonarqube I've started a handler to solve this issue here: |
The SonarQube 6.2-RC1 is now available, please have a try of the new SSO feature : https://sonarsource.bintray.com/Distribution/sonarqube/sonarqube-6.2-RC1.zip. |
This is looking good so far. This biggest downside is needing to maintain 2 different "sites". One for token based auth and one for AD. |
Thanks @jabbera for your feedback, could you elaborate more about it by sending an email to https://groups.google.com/forum/#!forum/sonarqube ? Thanks |
Will do. I'm still working through some issues with ssl and sni on the forums but I'm optomistic that we'll get all this stuff sorted. |
@julienlancelot Posted. |
So 6.2 is out as stable now. What are we meant to do to get AD/SSO/LDAP/whatever working again? I would like my users to not have to have accounts created and to be able to visit the site and not have to enter a username/password. |
@psyvision you can try my IIS module. It works by using IIS as a reverse proxy. |
Thanks @jabbera I'll take a look into that. Unfortunately we have our environment already setup with IIS reverse proxy but it's one site/DNS name being used for the site and the scanners so this is going to get messy :( |
You can add my module to your site. The ordering is important. The scanner site doesn't need much if you look at the web.config. I just run it on a different port. |
@psyvision isn't 6.2 supposed to get rid of the need for a separate plugin to do reverse proxy authentication? I haven't bothered trying out my https://github.com/trajano/reverse-proxy-auth-sonar-plugin on 6.2 yet and I presumed I don't need to continue developing it because of the proposed changes to have it part of 6.2 core. |
@trajano I wish I knew - it's as clear as mud at the moment with all of the documentation on the matter /sarcasm |
@trajano from my point of view there is no need for that plugin anymore. |
@psyvision I've found a way to get it down to a single site through some simple heuristics. Feel free to test v0.11. (https://github.com/jabbera/IisRemoteUserTokenAuthentication/releases/tag/v0.11) |
@jabbera Thank you for letting me know. I'll see if I can find some time in the coming days to give it a try and feedback to you! |
same issue here... |
@yanlee26 feel free to try my iis module: https://github.com/jabbera/IisRemoteUserTokenAuthentication |
The Active Directory plugin is not compatible with SonarQube 6.0, because it's using rails to authenticate (which is not part of the API), but now the authentication is done in Java (https://jira.sonarsource.com/browse/SONAR-7732).
In order to fix the compatibility, 2 solutions :
The text was updated successfully, but these errors were encountered: