From 8559c071ee700cce7acfef52021acb174faf9155 Mon Sep 17 00:00:00 2001 From: Michal Zgliczynski Date: Mon, 18 Nov 2024 13:44:08 +0100 Subject: [PATCH 1/3] Remove
as unsupported html tag --- .../html/checks/sonar/UnsupportedTagsInHtml5Check.java | 1 - .../html/checks/scripting/NestedJavaScriptCheckTest.java | 8 ++++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/sonar-html-plugin/src/main/java/org/sonar/plugins/html/checks/sonar/UnsupportedTagsInHtml5Check.java b/sonar-html-plugin/src/main/java/org/sonar/plugins/html/checks/sonar/UnsupportedTagsInHtml5Check.java index a8c50c16c..d112ff78f 100644 --- a/sonar-html-plugin/src/main/java/org/sonar/plugins/html/checks/sonar/UnsupportedTagsInHtml5Check.java +++ b/sonar-html-plugin/src/main/java/org/sonar/plugins/html/checks/sonar/UnsupportedTagsInHtml5Check.java @@ -39,7 +39,6 @@ public class UnsupportedTagsInHtml5Check extends AbstractPageCheck { "FONT", "FRAME", "FRAMESET", - "HGROUP", "ISINDEX", "LISTING", "MARQUEE", diff --git a/sonar-html-plugin/src/test/java/org/sonar/plugins/html/checks/scripting/NestedJavaScriptCheckTest.java b/sonar-html-plugin/src/test/java/org/sonar/plugins/html/checks/scripting/NestedJavaScriptCheckTest.java index cd0228819..6e7ee90f8 100644 --- a/sonar-html-plugin/src/test/java/org/sonar/plugins/html/checks/scripting/NestedJavaScriptCheckTest.java +++ b/sonar-html-plugin/src/test/java/org/sonar/plugins/html/checks/scripting/NestedJavaScriptCheckTest.java @@ -61,4 +61,12 @@ public void nested_script_node_should_result_in_a_violation() { .noMore(); } + @Test + public void nested_script_node_should_result_in_a_violation() { + NestedJavaScriptCheck check = new NestedJavaScriptCheck(); + HtmlSourceCode sourceCode = TestHelper.scan(new File("src/test/resources/checks/NestedJavaScriptCheck/Repro.html"), check); + checkMessagesVerifier.verify(sourceCode.getIssues()) + .noMore(); + } + } From bd8d3d10108048b957e41a9b6ecc051883fe4aaf Mon Sep 17 00:00:00 2001 From: Michal Zgliczynski Date: Mon, 18 Nov 2024 13:51:03 +0100 Subject: [PATCH 2/3] remove untouched --- .../html/checks/scripting/NestedJavaScriptCheckTest.java | 8 -------- 1 file changed, 8 deletions(-) diff --git a/sonar-html-plugin/src/test/java/org/sonar/plugins/html/checks/scripting/NestedJavaScriptCheckTest.java b/sonar-html-plugin/src/test/java/org/sonar/plugins/html/checks/scripting/NestedJavaScriptCheckTest.java index 6e7ee90f8..cd0228819 100644 --- a/sonar-html-plugin/src/test/java/org/sonar/plugins/html/checks/scripting/NestedJavaScriptCheckTest.java +++ b/sonar-html-plugin/src/test/java/org/sonar/plugins/html/checks/scripting/NestedJavaScriptCheckTest.java @@ -61,12 +61,4 @@ public void nested_script_node_should_result_in_a_violation() { .noMore(); } - @Test - public void nested_script_node_should_result_in_a_violation() { - NestedJavaScriptCheck check = new NestedJavaScriptCheck(); - HtmlSourceCode sourceCode = TestHelper.scan(new File("src/test/resources/checks/NestedJavaScriptCheck/Repro.html"), check); - checkMessagesVerifier.verify(sourceCode.getIssues()) - .noMore(); - } - } From fc39f7bba3412afd422cb6fa21fa863c361d8791 Mon Sep 17 00:00:00 2001 From: Michal Zgliczynski Date: Mon, 18 Nov 2024 14:20:22 +0100 Subject: [PATCH 3/3] update ruling --- .../resources/expected/Web-UnsupportedTagsInHtml5Check.json | 3 --- 1 file changed, 3 deletions(-) diff --git a/its/ruling/src/test/resources/expected/Web-UnsupportedTagsInHtml5Check.json b/its/ruling/src/test/resources/expected/Web-UnsupportedTagsInHtml5Check.json index 958029b20..1db479415 100644 --- a/its/ruling/src/test/resources/expected/Web-UnsupportedTagsInHtml5Check.json +++ b/its/ruling/src/test/resources/expected/Web-UnsupportedTagsInHtml5Check.json @@ -11274,9 +11274,6 @@ 177, 177 ], -"project:external_webkit-jb-mr1/PerformanceTests/Parser/resources/html5.html": [ -192 -], "project:external_webkit-jb-mr1/Source/JavaScriptCore/tests/mozilla/README-jsDriver.html": [ 80, 162