From 77dedc29bdc83fb345ef79e88d8f2492ec50c1ad Mon Sep 17 00:00:00 2001 From: Derek K Date: Mon, 4 Nov 2024 17:07:47 -0500 Subject: [PATCH 1/2] Fixing typo in the word defining --- .../html/checks/accessibility/NoRedundantRolesCheck.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sonar-html-plugin/src/main/java/org/sonar/plugins/html/checks/accessibility/NoRedundantRolesCheck.java b/sonar-html-plugin/src/main/java/org/sonar/plugins/html/checks/accessibility/NoRedundantRolesCheck.java index 9ad074ca..a6eb4965 100644 --- a/sonar-html-plugin/src/main/java/org/sonar/plugins/html/checks/accessibility/NoRedundantRolesCheck.java +++ b/sonar-html-plugin/src/main/java/org/sonar/plugins/html/checks/accessibility/NoRedundantRolesCheck.java @@ -70,7 +70,7 @@ public void startElement(TagNode element) { } createViolation(element, String.format( - "The element %s has an implicit role of %s. Definig this explicitly is redundant and should be avoided.", + "The element %s has an implicit role of %s. Defining this explicitly is redundant and should be avoided.", element.getNodeName(), implicitRole)); } } From 6ba98515a761d2656241ac81ccfa6db055f7b3ec Mon Sep 17 00:00:00 2001 From: Derek K Date: Mon, 4 Nov 2024 17:09:02 -0500 Subject: [PATCH 2/2] Updating test to corrected spelling --- .../checks/accessibility/NoRedundantRolesCheckTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sonar-html-plugin/src/test/java/org/sonar/plugins/html/checks/accessibility/NoRedundantRolesCheckTest.java b/sonar-html-plugin/src/test/java/org/sonar/plugins/html/checks/accessibility/NoRedundantRolesCheckTest.java index 8f6166c7..2989c15b 100644 --- a/sonar-html-plugin/src/test/java/org/sonar/plugins/html/checks/accessibility/NoRedundantRolesCheckTest.java +++ b/sonar-html-plugin/src/test/java/org/sonar/plugins/html/checks/accessibility/NoRedundantRolesCheckTest.java @@ -37,7 +37,7 @@ void html() { checkMessagesVerifier.verify(sourceCode.getIssues()) .next().atLine(1) .withMessage( - "The element button has an implicit role of button. Definig this explicitly is redundant and should be avoided.") + "The element button has an implicit role of button. Defining this explicitly is redundant and should be avoided.") .next().atLine(2) .noMore(); } @@ -50,7 +50,7 @@ void html_with_custom_property() { new File("src/test/resources/checks/NoRedundantRolesCheck.html"), check); checkMessagesVerifier.verify(sourceCode.getIssues()) - .next().atLine(6).withMessage("The element nav has an implicit role of navigation. Definig this explicitly is redundant and should be avoided.") + .next().atLine(6).withMessage("The element nav has an implicit role of navigation. Defining this explicitly is redundant and should be avoided.") .noMore(); } @@ -64,7 +64,7 @@ void html_with_invalid_custom_property() { check); checkMessagesVerifier.verify(sourceCode.getIssues()) .next().atLine(2) - .next().atLine(6).withMessage("The element nav has an implicit role of navigation. Definig this explicitly is redundant and should be avoided.") + .next().atLine(6).withMessage("The element nav has an implicit role of navigation. Defining this explicitly is redundant and should be avoided.") .noMore(); } }