Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SameSite attribute missing for form auth cookie #4365

Closed
Nothing4You opened this issue Mar 7, 2021 · 0 comments
Closed

SameSite attribute missing for form auth cookie #4365

Nothing4You opened this issue Mar 7, 2021 · 0 comments

Comments

@Nothing4You
Copy link

Describe the bug

Cookie SonarrAuth will be soon rejected because it has the SameSite attribute set to None or an invalid value, without the secure attribute. To know more about the SameSite attribute, read https://developer.mozilla.org/docs/Web/HTTP/Headers/Set-Cookie/SameSite

To Reproduce

  1. Visit sonarr instance in Firefox
  2. Check browser console

Expected behavior
No warnings.

Screenshots
-

Platform Information:

  • OS: macOS 11
  • Docker: No
  • Mono: 6.12.0.122
  • Browser and Version: Firefox 86.0
  • Sonarr Version: 3.0.4.1132
  • Sonarr Branch: phantom-develop

Trace Logs
-

Additional information
This was already reported upstream in NancyFx/Nancy#3002, however, upstream is no longer maintained as per NancyFx/Nancy#3010. There is a PR that supposedly fixes this at NancyFx/Nancy#3006, however, as the repository is archived this won't be added upstream anymore.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants