You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For 515 forward compatibility, I have had these five consts declared in a block of #if DM_VERSION < 515 in _version.dm#L66.
I also added these to suite's builtins.rs in #354.
From releases incorporating that PR, the parser chokes on the consts in the linked _version.dm and fails silently, emitting only a stock stddef'y json of the environment.
Replacing the consts with defines resolves the choke.
I believe the issue amounts to suite being basically a rolling release - things like builtins are only versioned in comments, and so it's possible to encounter situations that on the latest byond version would be a legitimate fail, but on earlier ones would not.
It would probably be a fairly significant amount of work to break up things by byond version and add a config option for a target version, and I'm no good with rust, so I'm not sure where to go with this besides saying that it's a thing.
The text was updated successfully, but these errors were encountered:
Spookerton
changed the title
parser fails silently on consts that conflict with builtins
environment parser fails silently on consts that conflict with builtins
Oct 12, 2023
For 515 forward compatibility, I have had these five consts declared in a block of
#if DM_VERSION < 515
in _version.dm#L66.I also added these to suite's builtins.rs in #354.
From releases incorporating that PR, the parser chokes on the consts in the linked _version.dm and fails silently, emitting only a stock stddef'y json of the environment.
Replacing the consts with defines resolves the choke.
I believe the issue amounts to suite being basically a rolling release - things like builtins are only versioned in comments, and so it's possible to encounter situations that on the latest byond version would be a legitimate fail, but on earlier ones would not.
It would probably be a fairly significant amount of work to break up things by byond version and add a config option for a target version, and I'm no good with rust, so I'm not sure where to go with this besides saying that it's a thing.
The text was updated successfully, but these errors were encountered: