Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot compile on MacOS (M2 MB Air) #90

Open
amycol opened this issue Jan 9, 2025 · 4 comments
Open

Cannot compile on MacOS (M2 MB Air) #90

amycol opened this issue Jan 9, 2025 · 4 comments

Comments

@amycol
Copy link

amycol commented Jan 9, 2025

I cannot get Pineflash to compile on MacOS, M2 Macbook Air. Following the manual build instructions I get this after cargo build --release:

amy@Mac PineFlash % cargo build --release
   Compiling pineflash v0.5.5 (/Users/amy/Documents/Projects/Pinecil/PineFlash)
error: 1 positional argument in format string, but no arguments were given
   --> src/main.rs:532:88
    |
532 |         Err(error) => panic!("A massive error occured, not sure whats goin on here: \n {}"),
    |                                                                                        ^^

warning: unused imports: `ImageSource` and `epaint::ColorImage`
  --> src/main.rs:12:27
   |
12 | use eframe::{egui::{self, ImageSource}, epaint::ColorImage};
   |                           ^^^^^^^^^^^   ^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

warning: unused variable: `error`
   --> src/main.rs:532:13
    |
532 |         Err(error) => panic!("A massive error occured, not sure whats goin on here: \n {}"),
    |             ^^^^^ help: if this is intentional, prefix it with an underscore: `_error`
    |
    = note: `#[warn(unused_variables)]` on by default

warning: `pineflash` (bin "pineflash") generated 2 warnings
error: could not compile `pineflash` (bin "pineflash") due to 1 previous error; 2 warnings emitted
@amycol
Copy link
Author

amycol commented Jan 9, 2025

Just tried the generic_unix_install.sh script and had the same error. I was expecting this but thought to try it anyway to rule out the possibility that I typed a command wrong or something.

@acuteaangle
Copy link
Contributor

acuteaangle commented Jan 10, 2025

Duplicate of gh-87

After cloning the repo, you could trying running either git checkout a823625 to revert the problematic commit, or git checkout 0.5.5 to get the latest release version.

@lepaapel
Copy link

Not sure that correct but helps me - just remove {} at src/main.rs:532

@acuteaangle
Copy link
Contributor

That works. The ‘better’ solution would be to replace the missing argument, as in gh-86.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants