Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few typos at FirstApplication #18

Open
alex-bender opened this issue Aug 6, 2023 · 3 comments
Open

A few typos at FirstApplication #18

alex-bender opened this issue Aug 6, 2023 · 3 comments

Comments

@alex-bender
Copy link

First, this method toggles the state of the current cell. Then it sends the message ==value== to the object stored in the instance variable ==mouseAction==. In ==LOGame >> newCellAt: i at: j== we created the block ==[self toggleNeighboursOfCellAt: i at: j ]== which will all the neighbors of a cell when it is evaluated, and we assigned this block to the ==mouseAction== instance variable of the cell. Therefore sending the ==value== message causes this block to be evaluated, and consequently the state of the neighboring cells will toggle.

which will all the neighbors of a cell when it is evaluated

Looks like a verb is missing


https://github.com/SquareBracketAssociates/NewPharoByExample9/blob/e184a12b3ae769ed5eb164d1c3e5ed2a51326451/Chapters/FirstApplication/FirstApplication.pillar#L165C16-L165C21

5 @ 5

Later in text referenced as 50 @ 50


https://github.com/SquareBracketAssociates/NewPharoByExample9/blob/e184a12b3ae769ed5eb164d1c3e5ed2a51326451/Chapters/FirstApplication/FirstApplication.pillar#L225C1-L225C872

and if even if we thought we did know

I'm not sure about this one, but looks weird to me

@Ducasse
Copy link
Member

Ducasse commented Aug 6, 2023

Thanks for the feedback!

@alex-bender
Copy link
Author

One more stylistic issue: the whitespace is missed after colon
image

@Ducasse
Copy link
Member

Ducasse commented Aug 12, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants