Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logo not clickable #122

Closed
maehr opened this issue Mar 13, 2024 · 0 comments · Fixed by #129
Closed

Logo not clickable #122

maehr opened this issue Mar 13, 2024 · 0 comments · Fixed by #129
Labels
bug Something isn't working

Comments

@maehr
Copy link
Member

maehr commented Mar 13, 2024

Current Behavior

Somehow the logo in the upper left corner is not clickable, even though it "should" be:

https://github.com/Stadt-Geschichte-Basel/stadtgeschichtebasel.ch/blob/d139493643754db1011dfd7a1b689cc2697619be/src/routes/%2Blayout.svelte#L69C1-L78C12

Reproduction / Steps To Reproduce

  1. Go to site
  2. Try to click

Anything else?

  • The bug was introduced by me. Untested code in prod. I am sorry...
@maehr maehr added the bug Something isn't working label Mar 13, 2024
@mtwente mtwente mentioned this issue Mar 13, 2024
Closed
7 tasks
maehr added a commit to maehr/stadtgeschichtebasel.ch that referenced this issue Mar 18, 2024
@maehr
fix: fix Stadt-Geschichte-Basel#122 and obsolete Stadt-Geschichte-Bas…
f850fe1 
…el#123
@maehr maehr mentioned this issue Mar 18, 2024
Merged
7 tasks
maehr added a commit that referenced this issue Mar 19, 2024
@maehr
Logo fix & chores (#129)
387dee7 
* fix: fix #122 and obsolete #123

* chore: update dependencies to latest and obsolete several PRs

* fix: remove unneccessary image

* fix: remove unused import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@maehr