Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Code coverage #6

Closed
1 task done
arkadiuszbachorski opened this issue Jun 17, 2024 · 1 comment · Fixed by #7
Closed
1 task done

Fix Code coverage #6

arkadiuszbachorski opened this issue Jun 17, 2024 · 1 comment · Fixed by #7
Assignees
@PSchmiedmayer
Labels
bug Something isn't working

Comments

@arkadiuszbachorski
Copy link
Collaborator

Problem

Code coverage doesn't report coverage for whole repo correctly

Solution

Code coverage should take whole repository into consideration

Additional context

#5 (comment)

Code of Conduct

  • I agree to follow this project's Code of Conduct and Contributing Guidelines
@arkadiuszbachorski arkadiuszbachorski added the bug Something isn't working label Jun 17, 2024
@arkadiuszbachorski arkadiuszbachorski mentioned this issue Jun 17, 2024
Merged
1 task
@PSchmiedmayer PSchmiedmayer mentioned this issue Jun 17, 2024
Merged
1 task
@PSchmiedmayer PSchmiedmayer linked a pull request Jun 17, 2024 that will close this issue
Update Testing Coverage Report #7
Merged
1 task
@PSchmiedmayer PSchmiedmayer self-assigned this Jun 17, 2024
@PSchmiedmayer PSchmiedmayer moved this to In Progress in ENGAGE-HF Planning Board Jun 17, 2024
PSchmiedmayer added a commit that referenced this issue Jun 17, 2024
@PSchmiedmayer
Update Testing Coverage Report (#7)
1094119 
# Update Testing Coverage Report

## ♻️ Current situation & Problem
- #6


## ⚙️ Release Notes 
- Improves jest configuration and adds codecov configuration.


### Code of Conduct & Contributing Guidelines 

By submitting creating this pull request, you agree to follow our [Code
of
Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md):
- [x] I agree to follow the [Code of
Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md).
@github-project-automation github-project-automation bot moved this from In Progress to Done in ENGAGE-HF Planning Board Jun 17, 2024
@PSchmiedmayer PSchmiedmayer mentioned this issue Jun 17, 2024
Open
1 task
@PSchmiedmayer
Copy link
Member

@arkadiuszbachorski I addressed this in a small PR that improves the jest configuration to properly report coverage for all typescript files. We might want to tweak this in #5 if we should exclude/include any additional files and probably pull that over to the NextJSTemplate once this is baked in: StanfordBDHG/NextJSTemplate#29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PSchmiedmayer PSchmiedmayer

Labels
bug Something isn't working
Projects
ENGAGE-HF Planning Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Testing Coverage Report StanfordBDHG/ENGAGE-HF-Web-Frontend
2 participants
@PSchmiedmayer @arkadiuszbachorski