Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't undo -- just swap with previous #910

Open
bchurchill opened this issue May 26, 2016 · 1 comment
Open

Don't undo -- just swap with previous #910

bchurchill opened this issue May 26, 2016 · 1 comment
Assignees

Comments

@bchurchill
Copy link
Member

bchurchill commented May 26, 2016

Performance improvement.

@jrkoenig
Copy link
Contributor

So I did a little perf test. Turns out there's about a 10% performance penalty for not using undo. It turns out Cfg's are much heavier weight than I thought, with dozens of std::vectors to copy and such resulting in a lot of allocations (which are relatively expensive). If we're not using the incremental recompute code, it might make sense to remove some of this cached data and/or change the layout to be more copy friendly.

This was on examples/{tutorial,parity}, which don't have many test cases and a single basic block so they run quickly (150k-250k iterations/sec) and recompute is cheap. There likely would be less relative penalty for examples like nacl that run at a few thousand iterations/sec and have control flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants