Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postprocessing should happen before verification #919

Open
bchurchill opened this issue Jul 6, 2016 · 5 comments
Open

postprocessing should happen before verification #919

bchurchill opened this issue Jul 6, 2016 · 5 comments

Comments

@bchurchill
Copy link
Member

When using the --results option, the verification sometimes fails because of an unsupported instruction that should be preprocessed away first.

bchurchill pushed a commit that referenced this issue Jul 7, 2016
@stefanheule
Copy link
Member

This is not the behavior of the verification at the very end (that's done even without --results). Shouldn't the two behave the same (either both postprocess before verification, or both do it after)?

@bchurchill
Copy link
Member Author

Yeah, both should verify after postprocessing. My thought is that what
the user sees is what should be verified.

Berkeley

On 07/07/2016 09:14 AM, Stefan Heule wrote:

This is not the behavior of the verification at the very end (that's
done even without --results). Shouldn't the two behave the same
(either both postprocess before verification, or both do it after)?


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#919 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAnG6VSeZ_vNNZQ4Py_vQvjjqDntJ_O1ks5qTSXngaJpZM4JGmmu.

@stefanheule
Copy link
Member

Okay, can you change the other place, too, then? Reopening the ticket.

@stefanheule stefanheule reopened this Jul 9, 2016
@bchurchill
Copy link
Member Author

I should be able to do this on Monday.

On 07/08/2016 07:43 PM, Stefan Heule wrote:

Okay, can you change the other place, too, then? Reopening the ticket.


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#919 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAnG6awaBNwHDeA8Cl0TjpQsZJDYAfP-ks5qTwrsgaJpZM4JGmmu.

@bchurchill
Copy link
Member Author

I haven't yet done this, because while the fix is easy, it's a pain to find an example to test this on. It's not on anyone's critical path, but it should get done sometime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants