Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeviceStateAccessor: fix incorrect initial parameter propagation; restore ability to connect to devices #53

Merged
merged 2 commits into from
Nov 23, 2024
Merged

DeviceStateAccessor: fix incorrect initial parameter propagation; restore ability to connect to devices #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3db4758
fix incorrect `initial` parameter propagation
lukaskollmer Nov 22, 2024
dfe0618
make swiftlint happy
lukaskollmer Nov 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/SpeziBluetooth/Model/PropertySupport/DeviceStateAccessor.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ extension DeviceStateAccessor {
/// strictly if the value changes.
/// - action: The change handler to register.
public func onChange(initial: Bool = false, perform action: @escaping @Sendable (Value) async -> Void) {
onChange(initial: true) { _, newValue in
onChange(initial: initial) { _, newValue in
await action(newValue)
}
}
Expand Down
8 changes: 4 additions & 4 deletions Sources/SpeziBluetooth/Modifier/AutoConnectModifier.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ extension View {
/// if we don't hear back from the device. Minimum is 1 second. Supply `nil` to use default the default value or a value from the environment.
/// - Returns: The modified view.
@MainActor
public func autoConnect( // swiftlint:disable:this function_default_parameter_at_end
enabled: Bool = true,
public func autoConnect(
enabled: Bool = true, // swiftlint:disable:this function_default_parameter_at_end
with bluetooth: Bluetooth,
minimumRSSI: Int? = nil,
advertisementStaleInterval: TimeInterval? = nil
Expand Down Expand Up @@ -60,8 +60,8 @@ extension View {
/// if we don't hear back from the device. Minimum is 1 second. Supply `nil` to use default the default value or a value from the environment.
/// - Returns: The modified view.
@MainActor
public func autoConnect( // swiftlint:disable:this function_default_parameter_at_end
enabled: Bool = true,
public func autoConnect(
enabled: Bool = true, // swiftlint:disable:this function_default_parameter_at_end
with bluetoothManager: BluetoothManager,
discovery: Set<DiscoveryDescription>,
minimumRSSI: Int? = nil,
Expand Down
8 changes: 4 additions & 4 deletions Sources/SpeziBluetooth/Modifier/ScanNearbyDevicesModifier.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,8 @@ extension View {
/// if we don't hear back from the device. Minimum is 1 second. Supply `nil` to use default the default value or a value from the environment.
/// - autoConnect: If enabled, the bluetooth manager will automatically connect to the nearby device if only one is found.
/// - Returns: The modified view.
public func scanNearbyDevices( // swiftlint:disable:this function_default_parameter_at_end
enabled: Bool = true,
public func scanNearbyDevices(
enabled: Bool = true, // swiftlint:disable:this function_default_parameter_at_end
with bluetooth: Bluetooth,
minimumRSSI: Int? = nil,
advertisementStaleInterval: TimeInterval? = nil,
Expand Down Expand Up @@ -185,8 +185,8 @@ extension View {
/// if we don't hear back from the device. Minimum is 1 second. Supply `nil` to use default the default value or a value from the environment.
/// - autoConnect: If enabled, the bluetooth manager will automatically connect to the nearby device if only one is found.
/// - Returns: The modified view.
public func scanNearbyDevices( // swiftlint:disable:this function_default_parameter_at_end
enabled: Bool = true,
public func scanNearbyDevices(
enabled: Bool = true, // swiftlint:disable:this function_default_parameter_at_end
with bluetoothManager: BluetoothManager,
discovery: Set<DiscoveryDescription>,
minimumRSSI: Int? = nil,
Expand Down
Loading