Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: Add detailed node info #89

Open
1 task done
kn0wmad opened this issue Jul 28, 2022 · 3 comments
Open
1 task done

[feat]: Add detailed node info #89

kn0wmad opened this issue Jul 28, 2022 · 3 comments
Assignees
Labels
Enhancement New feature or request Needs Scoping Requirements are not fully defined

Comments

@kn0wmad
Copy link
Contributor

kn0wmad commented Jul 28, 2022

Prerequisites

  • I have searched for existing issues that already suggest this feature.

Describe the Feature Request

List the number and host info of connected peers. This is may be better suited to a UI Dashboard, depending on how far out that feature is

Describe the Use Case

Quickly view connected peers and info about them

Describe Preferred Solution

Perhaps throw into Properties, but a UI Dashboard is ideal

Describe Alternatives

No response

Anything else?

No response

@kn0wmad kn0wmad added Enhancement New feature or request Needs Scoping Requirements are not fully defined labels Jul 28, 2022
@BitcoinMechanic
Copy link
Contributor

+1 would love to see. This is perhaps us just replicating something that appears in Bitcoin Core QT anyway where you can hover and see at least how many nodes you're connected to.

@biotic21
Copy link
Contributor

+1 from me too for adding more detailed node info, especially about the network and peers. I just got started with embassyOS and really like it. For my previous bitcoin node, seeing the number of inbound connections was nice because it told me that I had things configured correctly to fully support the network. I took a shot at adding a Connections property here. Its value would have a format like this: "13 (3 in / 10 out)", similar to the Information tab in Bitcoin Core's node window.

Btw, reasons I didn't do a pull request:

  1. I'm new to using Github and have never done one.
  2. I've never done anything in Rust. My changes are basically just a guess by replicating what I saw above with the other properties.
  3. I only searched the repo for the property related stuff and don't know what else may be needed in other files in addition to what I changed.
  4. I'm not able to build and install and test my changes for myself. I don't want to blindly change code and propose it.

@chrisguida
Copy link
Contributor

chrisguida commented Dec 19, 2022

@biotic21 A PR is preferred. Just make it a draft pull request and we'll help you complete it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Needs Scoping Requirements are not fully defined
Projects
None yet
Development

No branches or pull requests

5 participants