Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that all notebooks run with the latest version of the code #802

Open
matteobachetti opened this issue Feb 15, 2024 · 5 comments
Open
Labels
docs Issues regarding the documentation. good first issue If you're new to Stingray and want to contribute, start here. help wanted We need additional help with these issues!
Milestone

Comments

@matteobachetti
Copy link
Member

As the title says.

@matteobachetti matteobachetti added help wanted We need additional help with these issues! good first issue If you're new to Stingray and want to contribute, start here. docs Issues regarding the documentation. labels Feb 15, 2024
@matteobachetti matteobachetti added this to the version 2.0 milestone Feb 15, 2024
@AnonymousCodes911
Copy link
Contributor

AnonymousCodes911 commented Feb 15, 2024

Greetings @matteobachetti,
While checking the notebooks, i found an import error(?) and raised a PR please verify it and let me know if we have to find similar errors and raise PR accordingly.
Edit: Fixed nearly all the Notebooks and help needed to replicate files used in some of the Notebooks, refer commits
Thankyou

@kartikmandar
Copy link
Member

Hello @matteobachetti ,
I was going through the notebooks. Are only problems associated with the code are to be considered for a request or something as trivial as a spelling mistake should also be considered?

@matteobachetti
Copy link
Member Author

@kartikmandar spelling mistakes surely need to be fixed. Please try to reduce the changes to the bare minimum (e.g. do not re-run full notebooks for changes to the Markdown text)

@kartikmandar
Copy link
Member

Sure @matteobachetti I will keep that in mind.

@kartikmandar
Copy link
Member

Hello @matteobachetti I checked all the notebooks extensively and apart from the issues AnonymousCodes911 and I solved, everything was working fine. Also there still some warning messages to solve in LombScargle notebook and some issues in Pulsar notebook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues regarding the documentation. good first issue If you're new to Stingray and want to contribute, start here. help wanted We need additional help with these issues!
Projects
None yet
Development

No branches or pull requests

3 participants