Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.40.0: The results of Win32::GetOSName on Windows 11 are displayed as if it were Windows 10 #207

Closed
twata1 opened this issue Aug 16, 2024 · 3 comments
Labels
upstream module Issue is due to an upstream module

Comments

@twata1
Copy link

twata1 commented Aug 16, 2024

Hello,

I have run perl -MWin32 -e "print Win32::GetOSName" on a Windows 11 PC.
The results are displayed as if it were Windows 10.
See below.

----------------------------------------------
 Welcome to Strawberry Perl Portable Edition!
 * URL - https://www.strawberryperl.com/ 
 * See README.TXT for more info
---------------------------------------------- 
Perl executable: E:\strawberry-perl-5.40.0.1-64bit-portable\perl\bin\perl.exe
Perl version   : v5.40.0 / MSWin32-x64-multi-thread

E:\strawberry-perl-5.40.0.1-64bit-portable>perl -MWin32 -e "print Win32::GetOSName"
Win10Build 22631 (64-bit)

E:\strawberry-perl-5.40.0.1-64bit-portable>powershell -c "Get-ComputerInfo | Select OsName"

OsName
------
Microsoft Windows 11 Pro



E:\strawberry-perl-5.40.0.1-64bit-portable>

Thank you,

@shawnlaffan
Copy link
Contributor

I get the same on my Win11 laptop, except the build is 22621. However, looking at more of the Get-ComputerInfo details indicates this is working correctly.

WindowsProductName                                      : Windows 10 Enterprise
OsName                                                  : Microsoft Windows 11 Enterprise
OsVersion                                               : 10.0.22621

@twata1
Copy link
Author

twata1 commented Aug 16, 2024

@shawnlaffan
Thank you for reply.

I thought that if pull requests like perl-libwin32/win32#40 were applied on the Win32 module side, the results would be different.
I would wait for the Win32 module maintainer to incorporate such a pull request.

Thank you,

@shawnlaffan shawnlaffan added the upstream module Issue is due to an upstream module label Aug 17, 2024
@shawnlaffan
Copy link
Contributor

We do patch some CPAN modules but more commonly in cases where they otherwise do not build due to changes in Perl.

In this case the issue is best handled upstream by the module maintainer.

I'll close this issue now but please comment if there are reasons for it to remain open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream module Issue is due to an upstream module
Projects
None yet
Development

No branches or pull requests

2 participants