Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reserve HTTP server port #215

Merged
merged 2 commits into from
Aug 12, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 49 additions & 10 deletions Sources/SBTUITestTunnelClient/SBTUITestTunnelClient.m
Original file line number Diff line number Diff line change
Expand Up @@ -1062,26 +1062,65 @@ - (int)findOpenPort
addr.sin_family = AF_INET;
addr.sin_port = 0;
inet_aton("0.0.0.0", &addr.sin_addr);
int sock = socket(AF_INET, SOCK_STREAM, 0);
if (sock < 0) {
int server_sock = socket(AF_INET, SOCK_STREAM, 0);
if (server_sock < 0) {
return -1;
}
if (bind(sock, (struct sockaddr*) &addr, sizeof(addr)) != 0) {
if (bind(server_sock, (struct sockaddr*) &addr, sizeof(addr)) != 0) {
close(server_sock);
return -2;
}
if (getsockname(sock, (struct sockaddr*) &addr, &len) != 0) {
if (getsockname(server_sock, (struct sockaddr*) &addr, &len) != 0) {
close(server_sock);
return -3;
}

if (addr.sin_port > 1023) {
return addr.sin_port;
} else {

in_port_t port = addr.sin_port;

if (port <= 1023) {
close(server_sock);
NSLog(@"[SBTUITestTunnel] Invalid port assigned, trying again");
close(sock);
continue;
}

// Attempt to reserve the port by putting it in TIME_WAIT state. During this time,
// the system prevents other applications from binding to the same port,
// to prevent packets meant for the recently closed connection from being
// misdirected to the new application. Since SBTWebServer is utilizing SO_REUSEADDR on the
// server socket, we can bind to the port even though it's in TIME_WAIT state,
// effectively reserving it for our own use until we close the server socket.
if (listen(server_sock, 1)) {
close(server_sock);
return -4;
}

int client_sock = socket(AF_INET, SOCK_STREAM, 0);
if (client_sock < 0) {
close(server_sock);
return -5;
}

if (connect(client_sock, (struct sockaddr*) &addr, sizeof(addr))) {
close(server_sock);
close(client_sock);
return -6;
}

int accept_sock = accept(server_sock, nil, nil);
if (accept_sock < 0) {
close(server_sock);
close(client_sock);
return -7;
}

close(server_sock);
close(client_sock);
close(accept_sock);

return port;
}

return -4;
return -8;
}

#pragma mark - Error Helpers
Expand Down
Loading