Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve block highlighting #37

Open
idleberg opened this issue Sep 5, 2019 · 0 comments
Open

Improve block highlighting #37

idleberg opened this issue Sep 5, 2019 · 0 comments

Comments

@idleberg
Copy link
Collaborator

idleberg commented Sep 5, 2019

In my opinion, the highlighting of blocks (Section/SectionEnd, Function/FunctionEnd, PageEx/PageExEnd) should be adjusted to match that other languages. Specifically, the mentioned commands to open/close a block should be highlighted as other.keyword.nsis, while their names should be entity.name.function.nsis.

Adjusting Section is fairly complex, since there many cases to consider, e.g. optional quotes around the name, optional parameters, special prefixes and section indices.

Section NameOfSection
SectionEnd

Section "Name of Section with Spaces"
SectionEnd

Section -hiddenSection
SectionEnd

Section "-hidden section"
SectionEnd

Section # hidden section
SectionEnd

Section !boldSection
SectionEnd

Section "!bold section"
SectionEnd

Section /o "optional section"
SectionEnd

Section "section with named index" SECTION_INDEX
SectionEnd

All PRs to improve block highlighting are appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant