Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Goto Definition/Reference support #39

Open
idleberg opened this issue Sep 5, 2019 · 0 comments
Open

Add Goto Definition/Reference support #39

idleberg opened this issue Sep 5, 2019 · 0 comments

Comments

@idleberg
Copy link
Collaborator

idleberg commented Sep 5, 2019

This package currently lacks Goto Definition / Goto Reference support. As far as I know, there are at least four scenarios where this makes sense:

1. Functions

# Definition
Function someFunction
FunctionEnd

# Reference
Call someFunction

2. Macros

# Definition
!macro someMacro
!macroend

# Reference
!insertmacro someMacro

3. Defines

# Definition
!define VERSION "1.2.3"

# Reference
DetailPrint "This is version ${VERSION}"

4. Variables

# Definition
Var "someVar"

# Reference
DetailPrint "Printing $someVar"

Note: When variables are declared, no value is assigned. Hence, the benefit Goto Definition might be limited

Example:

# Definition
Var "someVar"

# Value assignment
StrCpy $someVar "World"

# Reference
DetailPrint "Hello $someVar"

# Value re-assignment
StrCpy $someVar "John Doe"

All PRs to add Goto Definition / Goto Reference support are appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant