Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEA servers not pulling games #217

Closed
kvahuja opened this issue Aug 4, 2017 · 10 comments
Closed

SEA servers not pulling games #217

kvahuja opened this issue Aug 4, 2017 · 10 comments

Comments

@kvahuja
Copy link
Contributor

kvahuja commented Aug 4, 2017

SERVER: SEA (public)

Here are the detilals...

This API call has a player "Kronos17" who on stream played a game with 5 more people all of them were T9-10. Yet the match is not shwing up in API.

The SS of the match data - https://cdn.discordapp.com/attachments/273223857337401344/343093128158248960/image.png

https://api.dc01.gamelockerapp.com/shards/sg/matches?filter[playerNames]=Kronos17&sort=-createdAt

Links to all players and their records - all of them have played several ranked games
https://www.vainsocial.com/player/Nikhil21
https://www.vainsocial.com/player/NomNomTNT
https://www.vainsocial.com/player/ConQuisTaDoR
https://www.vainsocial.com/player/DevourX
https://www.vainsocial.com/player/yoyoAjay
https://www.vainsocial.com/player/Kronos17

Possible spectators in matches were:
VGIF1 (can't pull in API)
VGIF2 (0 ranked matches)
VGIF4 (58 ranked matches)

@kvahuja
Copy link
Contributor Author

kvahuja commented Aug 4, 2017

here is another of the players who played 2 matches on stream both private draft.

https://api.dc01.gamelockerapp.com/shards/sg/matches?filter[playerNames]=Nikhil21&sort=-createdAt&filter[createdAt-start]=2017-08-01T13:42:05.377Z

@kvahuja
Copy link
Contributor Author

kvahuja commented Aug 4, 2017

URLs to API with players who played these matches

https://api.dc01.gamelockerapp.com/shards/sg/matches?filter[playerNames]=Xulfe&sort=-createdAt&filter[createdAt-start]=2017-08-01T13:42:05.377Z
https://api.dc01.gamelockerapp.com/shards/sg/matches?filter[playerNames]=Rishi0010&sort=-createdAt&filter[createdAt-start]=2017-08-01T13:42:05.377Z
https://api.dc01.gamelockerapp.com/shards/sg/matches?filter[playerNames]=MkD&sort=-createdAt&filter[createdAt-start]=2017-08-01T13:42:05.377Z

@BrianGLHF
Copy link
Contributor

I'm logged into my SEA account, just played a BR, it showed up. We can rule out that SEA is not pulling any games.

@kvahuja
Copy link
Contributor Author

kvahuja commented Aug 4, 2017

SEA is getting games - that's not an issue.

it's either no Private Draft games are getting pulled since 2.6 - check on VGMINER for same people i linked up - they have games in 2.5 but none in 2.6. or something peculiar with these matches

@Skillz4Killz
Copy link
Collaborator

SEA is getting Private Draft Matches confirmed. I have SEA Matches that are done for EZL Matches that are coming through on the API. I believe the issue is somewhere in one of three portions because they are the only differences from 1 match to another.

  1. Spectators
  2. Streaming Using In-Game Mobcrush Client
  3. Spectator Client

A game is set up in almost the same manner so if some matches are showing up they should all be showing up. The only differences that can occur between the setup of matches are listed.

Hope this helps.

@schneefux
Copy link
Contributor

I tried the first match with NomNomTNT and Kronos17.
Kronos17 (sg) has the player id 6477b444-f0bd-11e4-88c5-06d90c28bf1a and has a created_at of 2017-08-04T14:16:54Z.

curl -g "https://api.dc01.gamelockerapp.com/shards/sg/players?filter[playerNames]=Kronos17" -H "Authorization: Bearer $APIKEY" -H "X-TITLE-ID: semc-vainglory" -H "Accept: application/vnd.api+json" | jq "."

NomNomTNT (sg) has the player id d27d17ca-6324-11e5-b8b8-06d90c28bf1a and has a created_at of 2017-08-05T17:19:34Z. (same curl, different name)
DevourX (sg) has the player id 65a86d88-6cf8-11e5-9e50-06eb725f8a76 and has a created_at of 2017-08-04T11:46:31Z.

This query should return a private_party_draft match at 2017-08-04, played at about 18:00 (that was when @kvahuja reported the bug, he needs to confirm).

Looking at the accounts that spectate, I saw two names on recent streams: VGIF4 and VGIF1. Presumably, VGIF2 and VGIF3 are used as well.
Querying the API for those names:

  • VGIF1 cannot be found on /sg/players but has played two blitz_pvp_ranked match on April 11th with the playerID 100600dc-de2d-11e6-af62-06a9175d25fa, the query returns player objects. Looking up matches by the id gives the same results as the lookup by name. Looking up /sg/players by id returns a 404. Looking up /sg/players/{id} returns a 404.
curl -g "https://api.dc01.gamelockerapp.com/shards/sg/players?filter[playerNames]=VGIF1" -H "Authorization: Bearer $APIKEY" -H "X-TITLE-ID: semc-vainglory" -H "Accept: application/vnd.api+json" | jq "."  # should succeed
curl -g "https://api.dc01.gamelockerapp.com/shards/sg/matches?filter[playerNames]=VGIF1&filter[createdAt-start]=2017-04-01T00:00:00Z" -H "Authorization: Bearer $APIKEY" -H "X-TITLE-ID: semc-vainglory" -H "Accept: application/vnd.api+json" | jq "."  # returns matches?!
  • VGIF2 exists on /sg/players, and I can find matches casual and blitz_pvp_ranked.
  • VGIF3 exists on /sg/players with a createdAt in 2017-05, and I can find matches casual, blitz_pvp_ranked and casual_aral.
  • VGIF4 exists on /sg/players with a createdAt in 2017-08, and I can find matches ranked and casual_aral.

I suspect that data did not get stored on /players in the beginning of April due to #151, that VGIF1 is affected as an account that had no activity besides during the downtime where you accidentally discarded player object updates, and you are now rejecting matches with the spectator VGIF1 as invalid because the player object does not exist in your database.

@kvahuja
Copy link
Contributor Author

kvahuja commented Aug 6, 2017

they didnt use VGIF1 all day yesterday and still we cant get games

@svperfecta
Copy link
Contributor

Hey Folks - We looked, no matches are being missed. @schneefux is likely correct on #151. Its possible there was a game server issue or some other transient thing. I dont think this is enough to lose confidence in either the game systems or the api, as we compare quite frequently and don't see any discrepancies. I'm closing this because there's nothing we can do further to address this.

@svperfecta
Copy link
Contributor

hey @schneefux Just want to make sure you know that this should not work, and that is expected. We don't associate a match with a player unless they were on a team. Spectatorship doesn't really mean much, other than to give you a queue as to who was casting.

curl -g "https://api.dc01.gamelockerapp.com/shards/sg/matches?filter[playerNames]=VGIF1&filter[createdAt-start]=2017-04-01T00:00:00Z" -H "Authorization: Bearer $APIKEY" -H "X-TITLE-ID: semc-vainglory" -H "Accept: application/vnd.api+json" | jq "."  # returns matches?!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants