-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Writing the cache takes a very long time on Windows #169
Comments
After talking to a few people about it, it seems that Github Actions Windows runners simply have very slow networking, so this is not something that can be easily fixed in this action. It might be possible to improve slightly by increasing the compression ratio on Windows, for example. |
Writing the cache on Windows is just painfully slow compared to macOS and Linux action runners. In my workflows though, it takes a very long time to compress the cache with a Zstd compression level of 10, and the network copy time is negligible by comparison. https://github.com/jqnatividad/qsv/actions/runs/8535984799/job/23383567613 Maybe the compression level is too high? |
It's not about network, but this command:
I remember reading about this |
That seems to be a different issue. That one is about extraction, but the step that seems to take a long time is compression at the end. |
I migrated to https://github.com/actions/cache/blob/main/examples.md#rust---cargo And even there Windows is slower both on extraction and compression *(but much better than rust-cache) |
This is also an issue for me on windows, I can't view the original workflow files posted with this issue but for me the workflow takes almost 3 minutes to restore the cache (see here). It seems to be the extraction step that is taking forever for me, not compression. |
The post-run phase of
rust-cache
takes a long time on our CI in https://github.com/rustsec/rustsec, but only on Windows.Here's a sample log that shows MacOS cache completing in 38 seconds: https://github.com/rustsec/rustsec/actions/runs/6002426049/job/16278755180?pr=969
And here's the same job on Windows-MSVC, with the post-run phase taking over 5 minutes: https://github.com/rustsec/rustsec/actions/runs/6002426049/job/16278755358?pr=969
This is something that we have consistently observed, not a one-off.
The job definition can be found here: https://github.com/rustsec/rustsec/blob/b6def7c9fa30d7da2b2f569a9cded0f041d68068/.github/workflows/cargo-audit.yml#L36-L54
The text was updated successfully, but these errors were encountered: