Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloner: lfs support #765

Open
sgaist opened this issue Nov 11, 2024 · 3 comments
Open

cloner: lfs support #765

sgaist opened this issue Nov 11, 2024 · 3 comments

Comments

@sgaist
Copy link
Collaborator

sgaist commented Nov 11, 2024

The current implementation of the cloner does not handle lfs content which means that people will get incomplete clones if the repository has such content and they will need to call git lfs pull manually.

Note that go git does not implement yet lfs support at all.

See the compatibility grid.

@leafty
Copy link
Member

leafty commented Dec 19, 2024

In the past, there had been many times when sessions would not start because lfs would use too much disk storage on clone (usually around 2x the current LFS data).

The minimum is to make LFS support opt-in (to make sure most sessions can start), and if possible provide disk size error messages to the user.

@sgaist
Copy link
Collaborator Author

sgaist commented Dec 19, 2024

@leafty these are good points.

Do you think we should also consider an option for shallow cloning ?

@leafty
Copy link
Member

leafty commented Dec 19, 2024

I think having a fetch depth option is most likely a low priority at the moment since cases where a git reflog reaches ~1GB or above are quite uncommon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants