Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should deck code start with E valid? #20

Open
jotarun opened this issue May 24, 2022 · 1 comment
Open

should deck code start with E valid? #20

jotarun opened this issue May 24, 2022 · 1 comment

Comments

@jotarun
Copy link

jotarun commented May 24, 2022

new version is out and i see a lot of sites using code like:
EUCQCAYCBIAQMDABAIDAUGRMAIDASHJPAUAQEBQJBQITSAICAEBAEMIDAEAQEKABAMBBIAIGBIPQ

which works on those site but not invalid in deckencoder.

It works once you change the initial to C
CUCQCAYCBIAQMDABAIDAUGRMAIDASHJPAUAQEBQJBQITSAICAEBAEMIDAEAQEKABAMBBIAIGBIPQ

I'm not sure which on is actually correct for the latest version, since old codes all starts with C

@dneto
Copy link

dneto commented May 30, 2022

Riot official implementation ignores the format when reading a deck code, as you can see here. The format is only using when generating a code from a given deck.

This implementation checks if the format is 1 which explains why those codes work with other libs and in-game client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants