Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure transport: allow seeing FULL details from a failed message #41

Open
weaverryan opened this issue Jun 20, 2022 · 2 comments
Open

Comments

@weaverryan
Copy link
Contributor

For the failure transport section, we should be able to click an individual message to be taken to a new page to see the FULL info and stacktrace for that failed message.

@rodnaph
Copy link
Contributor

rodnaph commented Jan 12, 2023

Here's a version of this we're currently using, is there any information in particular you saw important to be included on this page? At the moment it lists exception code, class and message, along with a basic rendering of the message object, and then stack trace...

image

It's been suggest we could more closely follow the output of messenger:failed:show, which seems like a good idea. I also wondered about using the vardumper component for the message output.

WDYT?

@weaverryan
Copy link
Contributor Author

This looks great! Man, this messing information still bothers the heck out of me - so I'd love to have it fixed :).

It's been suggest we could more closely follow the output of messenger:failed:show, which seems like a good idea. I also wondered about using the vardumper component for the message output.

That's the only thing I was thinking about too... specifically for rendering what the message class looks like. The logic isn't reusable, but you can see how it's done here - https://github.com/symfony/symfony/blob/6.3/src/Symfony/Component/Messenger/Command/AbstractFailedMessagesCommand.php#L138 - we indeed use VarDumper if it's available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants