Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to include note on delete transaction #67

Open
TCEchicago opened this issue Apr 6, 2017 · 2 comments
Open

Add ability to include note on delete transaction #67

TCEchicago opened this issue Apr 6, 2017 · 2 comments

Comments

@TCEchicago
Copy link

If I'm understanding the code correctly, it's currently not possible to include a note when canceling a transaction. The HTTPClient delete method will only accept the path as input.

Adding a note would be helpful to distinguish between different types of reasons for canceling a transaction. For example, we have use cases where a pending transaction can be canceled as part of a user account deletion or the user can directly request a cancel from our app.

trans.delete(node_id: user_node, trans_id: transaction_id, note: "End User Request" )
trans.delete(node_id: user_node, trans_id: transaction_id, note: "Account Delete" )

@stevula
Copy link
Contributor

stevula commented Apr 8, 2017

Hi @TCEchicago. The API itself (docs) doesn't support doing this via one request but you can accomplish it by making a DELETE and PATCH request in combination.

@TCEchicago
Copy link
Author

TCEchicago commented Apr 8, 2017

Ok thank you @stevula. Michelle from the Synapse support team originally responded to a question I emailed help@synapse and said it was possible "in the new CORE via the notes fields" I was hoping the API docs were just out of date. I'll take the PATCH request approach. Thank you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants