Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for DEPOSIT-US node type #85

Open
dchang opened this issue Oct 3, 2017 · 0 comments
Open

Add support for DEPOSIT-US node type #85

dchang opened this issue Oct 3, 2017 · 0 comments

Comments

@dchang
Copy link

dchang commented Oct 3, 2017

Trying to retrieve a DEPOSIT-US node via user.find_node(id: node_id) raises a KeyError: key not found: "DEPOSIT-US" error.

Looks like this would involve adding a new DepositUsNode class in line with the pattern surrounding the other node classes.

Also, changing:
https://github.com/synapsepay/SynapsePayRest-Ruby/blob/04f48e69f63c8a27422994f516d0a192bc543f9a/lib/synapse_pay_rest/models/node/node.rb#L95
to:

klass = NODE_TYPES_TO_CLASSES.[response['type']] || BaseNode 

should work in the meantime. Currently, fetch raises the error never reaching the default class.

@dchang dchang changed the title Add support for DEPOST-US node type Add support for DEPOSIT-US node type Oct 3, 2017
@lukeasrodgers lukeasrodgers mentioned this issue Aug 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant