Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing await for instantiateUser #66

Open
thepipster opened this issue Feb 2, 2020 · 3 comments
Open

Missing await for instantiateUser #66

thepipster opened this issue Feb 2, 2020 · 3 comments

Comments

@thepipster
Copy link

There is a missing await around the instantiateUser method in the lib/Client class

@thepipster thepipster changed the title Missing await Missing await for instantiateUser Feb 2, 2020
@thepipster
Copy link
Author

It's an easy fix, I would submit a pull request but I don't have the rights to create a branch. The fix is;

Change;

return instantiateUser({ data, headerObj, client: this });

to

return await instantiateUser({ data, headerObj, client: this });

@dguo
Copy link

dguo commented Apr 6, 2020

@thepipster, just FYI, you can fork the repo, create a branch in your fork, and then create a pull request from that branch.

@jenstroeger
Copy link
Contributor

Thanks @dguo, and yes @thepipster please follow the Fork and Pull Request procedure for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants