Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo does not handle different dependencies for the same package #91

Open
hgy59 opened this issue Nov 11, 2022 · 2 comments
Open

Repo does not handle different dependencies for the same package #91

hgy59 opened this issue Nov 11, 2022 · 2 comments

Comments

@hgy59
Copy link
Contributor

hgy59 commented Nov 11, 2022

We have lidarr packages for some archs that depend on mono (SPK_DEPENDS=mono) and others that do not (using dotnet).

When I install Lidarr on x64, the DSM package center forces you to install mono, despite the spk file to download does not have this dependency.

I will propose to remove all lidarr packages that depend on mono in the repository (and hope this will fix this issue).

A future redesign (probably the port to rust by @publicarray) should support packages with different dependencies

  • for different dependencies for DSM 6 vs DSM 7

I suppose this issue addresses the creation of the package-list sent to the Diskstations.
The creation of the package-list must be adjusted for #63 too.

@mreid-tt
Copy link
Contributor

@hgy59, came across this and was wondering if this is still an issue. If so, can you give a current example so I can take a more detailed look?

@hgy59
Copy link
Contributor Author

hgy59 commented Feb 26, 2024

@hgy59, came across this and was wondering if this is still an issue. If so, can you give a current example so I can take a more detailed look?

An example (lidarr) is given above.
Until revision 9 lidarr had a conditional dependency (SPK_DEPENDS = mono...) for archs not supporting dotnet.
As the repo does not contain revisions < 10 for the lidarr package, this is not an issue anymore.

The db design still does not allow arch specific package dependencies.
E.g. we cannot have arch specific Python Versions in SPK_DEPENDS (like older python with openssl 1.1 for qoriq) because the SPK_DEPENDS goes into the version table of the repo as field dependencies and counts for all archs of a revision (field version in the version table).

Another example is the vim package. The python dependency is omitted since vim is supported for archs that do not support python 3.11 (and python integration is an optional feature anyway).

It is hard to say whether we really need this feature.
We might solve different dependencies with dedicated packages (like lidarr for archs supporting dotnet and lidarr-mono for others).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants