Gitea installer creates shared folder on wrong volume #5481
Comments
|
You misinterpreted things. The package is not asking on which volume to store the package itself. During the installation the package ask for a volume where to create the shared folder which you can define in the next question. |
|
Hi BenjV: Thank you for your time. I fear that you have misunderstood "one for the package" -- I was referring to the first of two wizard pages that ask volume questions. Please reread this issue. To summarize: The wizard asks and I answer:
The installer then creates a new shared folder on the wrong volume This is a bug. The user should not be able to select "Volume 3" on the basic config page and have a folder created on Volume 1. And, as mentioned, it then causes the downstream installer to fail -- it pre-populates its forms with /volume3/, but the installer has created the folder on /volume1/, which is the wrong volume. |
Thank you, I do already understand this! Please try the reproduction steps I provided -- as you will see, it asks for a volume twice, then uses the wrong one. |
|
I cannot test it because I do not have a Nas with multiple volumes. When you start the package and you are getting the config page, are alle the defaults volume1 or are they volume3 ? As a workaround you could create a shared folder named 'git' on volume3 yourself and grant the "system internal user" sc-gitea access. |
|
Hi BenjV -- sorry that you are not able to test the bug.
When I start the package and get the web config page, the gitea shared folder is pre-listed on the web config page as "/volume3/git/gitea-repositories". However, the install script actually created and gave sc-gitea permissions to a different folder, "/volume1/git/gitea-repositories." So:
Thanks. Another workaround is to set both "Select a destination volume" and "Basic Config: Select a volume" both the same volume. This installs correctly. |
|
@wkobiela is it possible that you can have a look? |
|
The problem is partly a DSM 6 issue and partly the package. The share should first be created in the preinstall phase with the "synoshare" command but there it only creates a folder with the "mkdir" command. I created a package for you, so you can test it. |
|
@BenjV can you provide your fork link/code changes? Is your package fixing the problem? I'm not able to reproduce this, as I do not have multiple shares |
|
@jeremydouglass @wkobiela DSM always creates shared folders on the same volume as the package is installed to, when the share is created at installation time. If you want to use a different volume for the shared folder of gitea, than you have to manually create that shared folder in DSM and use the respective volume. Than you can chose the name of that folder in the installation wizard. @publicarray, @th0ma7 IMHO we need a redesign regarding packages with shared folder usage for DSM 7 (and DSM 6 with
related packages so far:
|
|
This issue was addressed in #5929. |
Is this a new Bug?
Package Name
Gitea
Package Version
1.17.3-10
Device Model
DS1019+
Device Architecture
x86_64
Firmware Version
DSM 6.2.4-25556 Update 6
What happened?
The Gitea package install wizard asks for two separate volumes: one volume on the first wizard page
for the package"to install the software", one volume on the second wizard pagefor the repository shared folder"to use for the gitea folder". It then incorrectly sets up a Shared Folder and user (sc-gitea) on the wrong volume. This bug is only exposed if the user chooses two different volumes during the package install wizard.If the user configures with two different volumes -- e.g. "software" on Volume 1 and "folder" on Volume 3 -- the installer incorrectly creates the shared folder on the wrong volume, Volume 1. Clicking "Open" on the installed package launches the Gitea Initial Configuration webpage at :8418, and pre-populates the shared folder field with "/volume3/git/gitea-repositories" -- however, no such shared folder exists, because the wizard installer created the Shared Folder on the wrong volume, so submitting the web installer form fails with a permissions error:
Reproduction steps
Related files: https://github.com/SynoCommunity/spksrc/blob/3f0b2c5acb8c3c59853e053618c1c264fb2efcd3/spk/gitea/src/wizard/install_uifile
Install Log
Service Log
No response
Other Logs
No response
The text was updated successfully, but these errors were encountered: