Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Entra ID login_hint parameter #383

Open
MichaelGrafnetter opened this issue Jan 14, 2025 · 1 comment
Open

Incorrect Entra ID login_hint parameter #383

MichaelGrafnetter opened this issue Jan 14, 2025 · 1 comment

Comments

@MichaelGrafnetter
Copy link

Hi, I have discovered an issue in the Microsoft Entra ID OpenID Connect SSO plugin. Due to a bug in login_hint ID token claim handling, external/B2B Entra ID accounts cannot re-authenticate in SysReptor.

Current behavior

When SysReptor tries to re-authenticate an external Entra ID user, a Microsoft personal account in this case (*@outlook.com or *@live.com), the following screen with random-ish phone number is presented by Entra ID:

image

Expected behavior

The user should instead see a prompt like this:

image

Possible solution

The root cause is that SysReptor does a pass-through of the login_hint claim from the ID token to Microsoft's authentication endpoint. This claim contains a reference to the original token issuer (Personal Microsoft accounts - https://sts.windows.net/9188040d-6c67-4c5b-b112-36a304b66dad) instead of a reference to the target token issuer (Microsoft Entra ID - https://login.microsoftonline.com/TenantID/v2.0). The right ID token claim value to send is preferred_username, with which it works seamlessly, at least based on my tests.

@MWedl
Copy link
Contributor

MWedl commented Jan 15, 2025

Thanks for reporting. We will update the login_hint to use preferred_username.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants