Add missing test coverage

[bnonni]

Test coverage is currently at ~48%. This is the minimum coverage needed for current development; however, ideally, we'd like to have 100% coverage.

[MuskanSaxena6]

.take

[github-actions]

Thanks for taking this issue! Let us know if you have any questions!

[MuskanSaxena6]

Am i supposed to set these values according to me: ISSUER_WEB5_PASSWORD=' ', ISSUER_WEB5_RECOVERY_PHRASE=' ' ?

[bnonni]

Am i supposed to set these values according to me: ISSUER_WEB5_PASSWORD=' ', ISSUER_WEB5_RECOVERY_PHRASE=' ' ?

@MuskanSaxena6 you can set them manually in a .env or if you look at issuer/src/config.ts you'll see the config object is looking for process.env.ISSUER_WEB5_PASSWORD and
process.env.ISSUER_WEB5_RECOVERY_PHRASE in the env or if null, coalesce to a function from the Mnemonic class to fill it. Setting these vars in .env is more for BYO-Keys. If you don't have a pre-existing Agent DID recovery phrase and password, I recommend allowing the Mnemonic class to auto-populate them. You can also use that same class to explicitly define those vars wherever you need them.

Recommendation
Because this is a test coverage issue, I recommend either letting the config.ts code handle the auto-population or importing Mnemonic and explicitly defining a new ISSUER_WEB5_PASSWORD and ISSUER_WEB5_RECOVERY_PHRASE in the test case you're writing. If you look in the issuer/tests folder and specifically the issuer/tests/issuer.spec.ts test file, you'll find good starting points for understanding what has been setup already and where to go from here. Looking at issuer.spec.ts and config.spec.ts, you can see there's only 2 tests for the issuer package. Ideally, we'd have coverage for all the parts of the issuer package code + the applicant, common and server code bases.

Feel free to send me your questions in the TBD Discord channel for #dcx. I tend to not see GitHub comments as quickly.

[MuskanSaxena6]

Am i supposed to set these values according to me: ISSUER_WEB5_PASSWORD=' ', ISSUER_WEB5_RECOVERY_PHRASE=' ' ?

@MuskanSaxena6 you can set them manually in a .env or if you look at issuer/src/config.ts you'll see the config object is looking for process.env.ISSUER_WEB5_PASSWORD and
process.env.ISSUER_WEB5_RECOVERY_PHRASE in the env or if null, coalesce to a function from the Mnemonic class to fill it. Setting these vars in .env is more for BYO-Keys. If you don't have a pre-existing Agent DID recovery phrase and password, I recommend allowing the Mnemonic class to auto-populate them. You can also use that same class to explicitly define those vars wherever you need them.

Recommendation
Because this is a test coverage issue, I recommend either letting the config.ts code handle the auto-population or importing Mnemonic and explicitly defining a new ISSUER_WEB5_PASSWORD and ISSUER_WEB5_RECOVERY_PHRASE in the test case you're writing. If you look in the issuer/tests folder and specifically the issuer/tests/issuer.spec.ts test file, you'll find good starting points for understanding what has been setup already and where to go from here. Looking at issuer.spec.ts and config.spec.ts, you can see there's only 2 tests for the issuer package. Ideally, we'd have coverage for all the parts of the issuer package code + the applicant, common and server code bases.

Feel free to send me your questions in the TBD Discord channel for #dcx. I tend to not see GitHub comments as quickly.

@bnonni thanks a lot , you could have easily given me the answer in a single line but you explained it in such a detailed manner, I'm learning a lot!!