From b421d0277b71686c0e36d5382aa1408105693a03 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Elias=20H=C3=A4u=C3=9Fler?= Date: Sun, 16 Jul 2023 09:03:59 +0200 Subject: [PATCH] [BUGFIX] Respect overridden properties in AbstractPageTree This changes all property accesses within AbstractPageTree to use static instead of self. Since the class is abstract and therefore subject to class inheritance, its properties may also change in subclasses. Using self to access them would hide potentially overridden properties (late static binding). --- Classes/Core/Acceptance/Helper/AbstractPageTree.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Classes/Core/Acceptance/Helper/AbstractPageTree.php b/Classes/Core/Acceptance/Helper/AbstractPageTree.php index f7886ebf..81765384 100644 --- a/Classes/Core/Acceptance/Helper/AbstractPageTree.php +++ b/Classes/Core/Acceptance/Helper/AbstractPageTree.php @@ -52,7 +52,7 @@ public function openPath(array $path) foreach ($path as $pageName) { $context = $this->ensureTreeNodeIsOpen($pageName, $context); } - $context->findElement(\Facebook\WebDriver\WebDriverBy::cssSelector(self::$treeItemAnchorSelector))->click(); + $context->findElement(\Facebook\WebDriver\WebDriverBy::cssSelector(static::$treeItemAnchorSelector))->click(); } /** @@ -65,7 +65,7 @@ public function getPageTreeElement() $I = $this->tester; $I->switchToIFrame(); return $I->executeInSelenium(function (\Facebook\WebDriver\Remote\RemoteWebDriver $webdriver) { - return $webdriver->findElement(\Facebook\WebDriver\WebDriverBy::cssSelector(self::$pageTreeSelector)); + return $webdriver->findElement(\Facebook\WebDriver\WebDriverBy::cssSelector(static::$pageTreeSelector)); }); } @@ -79,7 +79,7 @@ public function getPageTreeElement() protected function ensureTreeNodeIsOpen(string $nodeText, RemoteWebElement $context) { $I = $this->tester; - $I->see($nodeText, self::$treeItemSelector); + $I->see($nodeText, static::$treeItemSelector); /** @var RemoteWebElement $context */ $context = $I->executeInSelenium(function () use (