Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the package.json for Dependabot #1338

Closed
1 task done
oliverklee opened this issue Jun 6, 2024 · 5 comments · Fixed by #1463 or #1504
Closed
1 task done

Fix the package.json for Dependabot #1338

oliverklee opened this issue Jun 6, 2024 · 5 comments · Fixed by #1463 or #1504
Assignees
@linxpinx
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
4.0.0: Breaking c...

Comments

@oliverklee
Copy link
Contributor

oliverklee commented Jun 6, 2024 •
edited
Loading

Goal

The package.json is fixed

Acceptance criteria

  • no errors related to package.json in Dependabot

Additional information

It seems we have broken package.json in a way that throws Dependabot off:
https://github.com/FriendsOfTYPO3/tea/network/updates/886067788

Dependabot failed to update your dependencies because there was an error resolving your JavaScript dependency files.

Dependabot encountered the following error:

Dependabot uses Node.js v20.17.0 and NPM 10.8.2. Due to the engine-strict setting, the update will not succeed.
@oliverklee oliverklee added the bug Something isn't working label Jun 6, 2024
@oliverklee oliverklee added this to the 4.0.0: Breaking changes milestone Jun 6, 2024
@lukaszuznanski lukaszuznanski self-assigned this Jun 10, 2024
@oliverklee oliverklee added the good first issue Good for newcomers label Jul 30, 2024
@linxpinx linxpinx self-assigned this Sep 17, 2024
@oliverklee
Copy link
Contributor Author

We'll probably need to allow Node.js 20 in package.json as well to unbreak Dependabot.

@lukaszuznanski lukaszuznanski removed their assignment Sep 17, 2024
@oliverklee oliverklee moved this from In Progress to In Review in Best Practices Sprint Sep 17, 2024
@oliverklee oliverklee moved this from In Review to In Progress in Best Practices Sprint Sep 17, 2024
@oliverklee
Copy link
Contributor Author

Fixed by #1457.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Best Practices Sprint Sep 17, 2024
@oliverklee
Copy link
Contributor Author

Reopening as Dependabot still has problems:

https://github.com/FriendsOfTYPO3/tea/network/updates/886128238
Dependabot uses Node.js v20.17.0 and NPM 10.8.2. Due to the engine-strict setting, the update will not succeed.

@oliverklee oliverklee reopened this Sep 17, 2024
@oliverklee oliverklee moved this from Done to In Progress in Best Practices Sprint Sep 17, 2024
@oliverklee oliverklee changed the title Fix the package.json Fix the package.json for Dependabot Sep 17, 2024
@linxpinx linxpinx mentioned this issue Sep 17, 2024
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in Best Practices Sprint Sep 17, 2024
@oliverklee
Copy link
Contributor Author

No, still not solved: https://github.com/FriendsOfTYPO3/tea/network/updates/886222075

Reopening.

We should find out what this "engine-strict setting" is and how to work with it.

@oliverklee oliverklee reopened this Sep 17, 2024
@oliverklee oliverklee moved this from Done to In Progress in Best Practices Sprint Sep 17, 2024
@linxpinx
Copy link
Collaborator

Found this dependabot/dependabot-core#4072.
As far as I understand best would be to include the version dependabot needs.

@linxpinx linxpinx mentioned this issue Oct 30, 2024
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in Best Practices Sprint Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@linxpinx linxpinx

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
4.0.0: Breaking changes
3 participants
@linxpinx @oliverklee @lukaszuznanski