Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use exact version numbers for development dependencies in composer.json #1451

Closed
oliverklee opened this issue Sep 5, 2024 · 5 comments
Closed
Assignees
Labels
bug Something isn't working dependencies Pull requests that update a dependency file

Comments

@oliverklee
Copy link
Contributor

As long as we're using something like ^1.2.3 or ^1.2 for development dependencies, we risk our build breaking when a new version of a development dependency is released and it either includes breaking changes or requires changes to the PHPStan baseline.

To avoid this, we should use exact version numbers like 1.2.3 in for development dependencies in composer.json. The only exception are TYPO3 Core packages.

As we're using Dependabot to update our dependencies, having exact version number does in no way block updates to our development dependencies.

@oliverklee oliverklee added bug Something isn't working dependencies Pull requests that update a dependency file hacktoberfest labels Sep 5, 2024
@oliverklee oliverklee added this to the 4.0.0: Breaking changes milestone Sep 5, 2024
@SalmanDeveloperz
Copy link
Contributor

Hi @oliverklee,
I would like to work on this issue. Would you be assign it to me?

@oliverklee oliverklee self-assigned this Oct 2, 2024
@oliverklee
Copy link
Contributor Author

Hi @SalmanDeveloperz, I already finished this task in #1475, but forgot to link this ticket and to assign it to me. Sorry for this. :-(

Would you be willing to take a different ticket?

@SalmanDeveloperz
Copy link
Contributor

Hi @oliverklee,

Thank you for the update! No problem at all—I understand how things can get busy.

I’m definitely available and willing to take on a different ticket. Please let me know which one you’d like me to work on, and I’ll get started right away!

@oliverklee
Copy link
Contributor Author

@SalmanDeveloperz We've marked some tickets with the label hacktoberfest. Please feel free to browse through them and then comment on one that seems to be a good fit for what you're interested in and what you'd like to learn next with your current skill level).

@SalmanDeveloperz
Copy link
Contributor

Hi @oliverklee ,

Thank you for the update! I really appreciate the opportunity. I'm new to open source and eager to learn more about working with larger codebases. Currently, I’m focusing on learning PHP and Python, and I believe contributing to this project will be a great way to enhance my skills.

Could you please assign me the ticket "Rework the testing framework section in the docs #535"? I hope I can get that done!

Thanks again!
Best Regards,
Salman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants