From ee3547461a4d837e8a7ed0123ce111bba787c77f Mon Sep 17 00:00:00 2001
From: esurface <esurface@rti.org>
Date: Thu, 17 Oct 2024 20:35:06 -0400
Subject: [PATCH] Remove the saveComplete subject; it causes problems

---
 .../group-uploads-edit/group-uploads-edit.component.html       | 2 +-
 .../groups/group-uploads-edit/group-uploads-edit.component.ts  | 2 --
 .../tangy-forms-player/tangy-forms-player.component.ts         | 3 ---
 3 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/editor/src/app/groups/group-uploads-edit/group-uploads-edit.component.html b/editor/src/app/groups/group-uploads-edit/group-uploads-edit.component.html
index b88daa91a..7ba437294 100644
--- a/editor/src/app/groups/group-uploads-edit/group-uploads-edit.component.html
+++ b/editor/src/app/groups/group-uploads-edit/group-uploads-edit.component.html
@@ -1,2 +1,2 @@
 <app-breadcrumb [title]="title" [breadcrumbs]="breadcrumbs"></app-breadcrumb>
-<app-tangy-forms-player unlockFormResponses="true" #formPlayer></app-tangy-forms-player>
\ No newline at end of file
+<app-tangy-forms-player [skipSaving]="true" #formPlayer></app-tangy-forms-player>
\ No newline at end of file
diff --git a/editor/src/app/groups/group-uploads-edit/group-uploads-edit.component.ts b/editor/src/app/groups/group-uploads-edit/group-uploads-edit.component.ts
index 4bb64e497..662bb22f1 100644
--- a/editor/src/app/groups/group-uploads-edit/group-uploads-edit.component.ts
+++ b/editor/src/app/groups/group-uploads-edit/group-uploads-edit.component.ts
@@ -70,8 +70,6 @@ export class GroupUploadsEditComponent implements OnInit {
       // at this point the form has been locked by tangy-form
       // form player will ignore the save unless we force it to save
       await this.formPlayer.saveResponse(response, true)
-    })
-    this.formPlayer.$saveComplete.subscribe(async () => {
       this.router.navigate([`../`], { relativeTo: this.route })
     })
     await this.formPlayer.render(true, {disableComponents:['TANGY-GPS']})
diff --git a/editor/src/app/tangy-forms/tangy-forms-player/tangy-forms-player.component.ts b/editor/src/app/tangy-forms/tangy-forms-player/tangy-forms-player.component.ts
index f9e0b25a4..0a29fd2ff 100755
--- a/editor/src/app/tangy-forms/tangy-forms-player/tangy-forms-player.component.ts
+++ b/editor/src/app/tangy-forms/tangy-forms-player/tangy-forms-player.component.ts
@@ -41,7 +41,6 @@ export class TangyFormsPlayerComponent {
   $afterSubmit = new Subject()
   $resubmit = new Subject()
   $afterResubmit = new Subject()
-  $saveComplete = new Subject()
   rendered = false
   groupId: string
 
@@ -239,8 +238,6 @@ export class TangyFormsPlayerComponent {
       state = await this.tangyFormService.saveResponse(stateDoc)
     }
     this.response = state
-
-    this.$saveComplete.next(true)
   }
 
   print() {