From 9a908549b77f91052ef8c2457f8131ce3a63f8ed Mon Sep 17 00:00:00 2001 From: Tom Shelley Date: Fri, 19 Jan 2024 15:02:17 +0000 Subject: [PATCH 1/7] =?UTF-8?q?=E2=9C=85=20test=20CI=20check?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- integration_tests/dbt_project.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/integration_tests/dbt_project.yml b/integration_tests/dbt_project.yml index d5c685f..6bffe92 100644 --- a/integration_tests/dbt_project.yml +++ b/integration_tests/dbt_project.yml @@ -19,7 +19,6 @@ clean-targets: ["target", "dbt_packages"] models: tasman_dbt_mta_integration_tests: - vars: tasman_dbt_mta: incremental: "true" From 31bfcdde9e3cd457c3a089d439cfdd6762154bc0 Mon Sep 17 00:00:00 2001 From: Tom Shelley Date: Fri, 19 Jan 2024 15:08:35 +0000 Subject: [PATCH 2/7] =?UTF-8?q?=F0=9F=90=9B=20fix=20bad=20reference=20to?= =?UTF-8?q?=20snowflake=20account?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- integration_tests/profiles.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/integration_tests/profiles.yml b/integration_tests/profiles.yml index 1b1c963..35fa32a 100644 --- a/integration_tests/profiles.yml +++ b/integration_tests/profiles.yml @@ -1,7 +1,7 @@ tasman_integration_tests: outputs: snowflake-ci: - account: xt59823.eu-west-2.aws + account: {{ env_var('SNOWFLAKE_ACCOUNT') }} client_session_keep_alive: true database: {{ env_var('SNOWFLAKE_DATABASE_CI') }} user: {{ env_var('SNOWFLAKE_USER_CI') }} From ef49c91ab32659653e9c584c0163f80fef72d431 Mon Sep 17 00:00:00 2001 From: Tom Shelley Date: Fri, 19 Jan 2024 15:19:12 +0000 Subject: [PATCH 3/7] =?UTF-8?q?=F0=9F=9A=9A=20improve=20check=20naming?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/workflows/ci-check.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci-check.yml b/.github/workflows/ci-check.yml index c91e62a..3daebbe 100644 --- a/.github/workflows/ci-check.yml +++ b/.github/workflows/ci-check.yml @@ -1,4 +1,4 @@ -name: ci check +name: CI on: pull_request: @@ -9,7 +9,7 @@ concurrency: cancel-in-progress: true jobs: - ci-checks: + ci-check-snowflake: runs-on: ubuntu-latest defaults: run: From 5b96073e4d67a2c523e2328e8294549f22220575 Mon Sep 17 00:00:00 2001 From: Tom Shelley Date: Fri, 19 Jan 2024 15:19:30 +0000 Subject: [PATCH 4/7] =?UTF-8?q?=F0=9F=92=9A=20quote=20env=20vars=20for=20C?= =?UTF-8?q?I?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- integration_tests/profiles.yml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/integration_tests/profiles.yml b/integration_tests/profiles.yml index 35fa32a..e5ee577 100644 --- a/integration_tests/profiles.yml +++ b/integration_tests/profiles.yml @@ -1,13 +1,13 @@ tasman_integration_tests: outputs: snowflake-ci: - account: {{ env_var('SNOWFLAKE_ACCOUNT') }} + account: "{{ env_var('SNOWFLAKE_ACCOUNT') }}" client_session_keep_alive: true - database: {{ env_var('SNOWFLAKE_DATABASE_CI') }} - user: {{ env_var('SNOWFLAKE_USER_CI') }} - password: {{ env_var('SNOWFLAKE_PASSWORD_CI') }} - role: {{ env_var('SNOWFLAKE_ROLE_CI') }} - schema: {{ env_var('SNOWFLAKE_SCHEMA_CI') }} - warehouse: {{ env_var('SNOWFLAKE_WAREHOUSE_CI') }} + database: "{{ env_var('SNOWFLAKE_DATABASE_CI') }}" + user: "{{ env_var('SNOWFLAKE_USER_CI') }}" + password: "{{ env_var('SNOWFLAKE_PASSWORD_CI') }}" + role: "{{ env_var('SNOWFLAKE_ROLE_CI') }}" + schema: "{{ env_var('SNOWFLAKE_SCHEMA_CI') }}" + warehouse: "{{ env_var('SNOWFLAKE_WAREHOUSE_CI') }}" threads: 12 type: snowflake From bec97abb01d742f8bb727157357158f9ce471bbc Mon Sep 17 00:00:00 2001 From: Tom Shelley Date: Fri, 19 Jan 2024 15:27:52 +0000 Subject: [PATCH 5/7] =?UTF-8?q?=F0=9F=92=9A=20hardcode=20non=20secrets?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/workflows/ci-check.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci-check.yml b/.github/workflows/ci-check.yml index 3daebbe..f85f2ec 100644 --- a/.github/workflows/ci-check.yml +++ b/.github/workflows/ci-check.yml @@ -18,9 +18,9 @@ jobs: SNOWFLAKE_ACCOUNT: ${{ secrets.SNOWFLAKE_ACCOUNT }} SNOWFLAKE_USER_CI: ${{ secrets.SNOWFLAKE_CI_USER }} SNOWFLAKE_PASSWORD_CI: ${{ secrets.SNOWFLAKE_CI_USER_PASSWORD }} - SNOWFLAKE_DATABASE_CI: ${{ secrets.SNOWFLAKE_CI_DATABASE }} - SNOWFLAKE_ROLE_CI: ${{ secrets.SNOWFLAKE_CI_ROLE }} - SNOWFLAKE_WAREHOUSE_CI: ${{ secrets.SNOWFLAKE_CI_WAREHOUSE }} + SNOWFLAKE_DATABASE_CI: DBT_MTA_PACKAGE + SNOWFLAKE_ROLE_CI: PACKAGE_CI_ROLE + SNOWFLAKE_WAREHOUSE_CI: PACKAGE_DEV_WH SNOWFLAKE_SCHEMA_CI: DBT_CI_${{github.event.number}}_${{ github.actor }} # Creates a unique schema for each PR steps: - name: Checkout branch From f622edf98f96bb61475e0fb2486160473980b795 Mon Sep 17 00:00:00 2001 From: Tom Shelley Date: Fri, 19 Jan 2024 16:00:30 +0000 Subject: [PATCH 6/7] =?UTF-8?q?=F0=9F=92=9A=20remove=20compile=20step?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/workflows/ci-check.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/ci-check.yml b/.github/workflows/ci-check.yml index f85f2ec..a4b88f6 100644 --- a/.github/workflows/ci-check.yml +++ b/.github/workflows/ci-check.yml @@ -50,9 +50,8 @@ jobs: poetry run dbt deps - name: Check dbt compiles and CI Profiles work - id: check-dbt-compiles-and-ci-profiles-work + id: check-dbt-ci-profiles-work run: | - poetry run dbt compile --target snowflake-ci poetry run dbt debug --target snowflake-ci - name: dbt build on Snowflake From 272c73bfb51ebd218bfbe7d1479b29e3665d9a32 Mon Sep 17 00:00:00 2001 From: Tom Shelley Date: Fri, 19 Jan 2024 16:21:50 +0000 Subject: [PATCH 7/7] =?UTF-8?q?=F0=9F=92=9A=20fix=20typo?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/workflows/ci-check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci-check.yml b/.github/workflows/ci-check.yml index a4b88f6..0db1714 100644 --- a/.github/workflows/ci-check.yml +++ b/.github/workflows/ci-check.yml @@ -57,4 +57,4 @@ jobs: - name: dbt build on Snowflake id: dbt-build-snowflake run: | - potery run dbt build --full-refresh --target snowflake-ci + poetry run dbt build --full-refresh --target snowflake-ci