no pain on switching species to NO_PAIN one #12507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog status: ✔️ |
Co-authored-by: NinjaPikachuska <[email protected]>
NinjaPikachuska
previously approved these changes
Nov 23, 2023
| @@ -1398,6 +1398,10 @@ | |||
|
|
|||
| maxHealth = species.total_health | |||
|
|
|||
| if(species.flags[NO_PAIN]) | |||
| shock_stage = 0 | |||
There was a problem hiding this comment.
я бы предпочёл заменить это на геттеры-сеттеры и тогда проблема была бы на 100% решена потому-что при получении флага геттер бы возвращал 0
NinjaPikachuska
dismissed
their stale review
подсказал в личке что делать с геттером и сеттером, ждем пока их
volas
requested changes
Dec 1, 2023
volas
approved these changes
Dec 8, 2023
|
в целом и так ок, гетеры/сетеры было бы хорошим бонусом но можно потом получить |
TauKitty
added a commit
to TauCetiStation/ClassicChangelog
that referenced
this pull request
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание изменений
Прок set_species ставит болевой шок на 0 если у целевого гуманоида флаг игнорирования боли, сейчас если раса гуманоида сменяется в течение раунда шок остается навсегда без возможности снять кроме как педально
resolves #9654
Почему и что этот ПР улучшит
Авторство
Чеинжлог
🆑