Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes some discord rpc issues #62

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fixes some discord rpc issues #62

wants to merge 1 commit into from

Conversation

Foxinauci
Copy link
Contributor

@Foxinauci Foxinauci commented Oct 12, 2024 •
edited
Loading

Hello, I tried fixing some discord-rpc issues I noticed. Mainly:

#47 Spamming next causing discord rpc to desync.

Spamming pause and unpause causing discord rpc to show the play activity rather than pause on pause.

Clicking on the seekbar when paused causing discord rpc to show the play activity to show rather than the pause one. (Since it is still technically paused.)

My apologies if code is bad I mainly want opinions on it.

@Foxinauci Foxinauci changed the title Fixes some discord rpc issues (Ignore all icons related stuff those are in another pr) Fixes some discord rpc issues Oct 12, 2024
@xDalete
Copy link
Contributor

xDalete commented Oct 14, 2024 •
edited
Loading

when you do a pr that fixes a known issue you should mention it to make it clear
just add "#" and the issue number to the description
like this: #47
doing this, anyone who opens the issue will see that there's already a pr for that

@Foxinauci
Copy link
Contributor Author

when you do a pr that fixes a known issue you should mention it to make it clear just add "#" and the issue number to the description like this: #47 doing this, anyone who opens the issue will see that there's already a pr for that

I think I did what you said. Except for that was there anything else you noticed with the code or pr that I could do better next time? Would like to know since I am not used to GitHub fully.

@Foxinauci
Copy link
Contributor Author

I guess editing it in doesn't mention it in the issue though, I'll know for next time!

@hrfarmer hrfarmer linked an issue Oct 14, 2024 that may be closed by this pull request
Skipping song to fast breaks discord rpc #47
Open
@hrfarmer
Copy link
Collaborator

hrfarmer commented Oct 14, 2024 •
edited
Loading

image

can also just do it on the sidebar as well if it doesn't link through text

@xDalete
Copy link
Contributor

xDalete commented Oct 14, 2024 •
edited
Loading

image

can also just do it on the sidebar as well if it doesn't link through text

only collaborators can do that
contributors cant see the edit button
image

@xDalete
Copy link
Contributor

xDalete commented Oct 14, 2024

I guess editing it in doesn't mention it in the issue though, I'll know for next time!

editing does mention it
it just was already mentioned by my comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaptSiro CaptSiro Awaiting requested review from CaptSiro CaptSiro will be requested when the pull request is marked ready for review CaptSiro is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skipping song to fast breaks discord rpc
3 participants
@Foxinauci @xDalete @hrfarmer