Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File requests to SOME_URL/undefined for beatmaps with no background #81

Open
Paladynee opened this issue Oct 16, 2024 · 6 comments
Open

Comments

@Paladynee
Copy link
Contributor

Paladynee commented Oct 16, 2024

image

image

requests made to normal_url/undefined shows that the normal_url points to a valid osu beatmap without a background

with beathmaps with a valid image residing in /undefined it will show the image

image

@Paladynee Paladynee changed the title File requests to SOME_URL/undefined or project root File requests to SOME_URL/undefined for beatmaps with no background Oct 16, 2024
@Paladynee
Copy link
Contributor Author

as a side note, the program also makes file requests to the project root (folder)

@hrfarmer hrfarmer self-assigned this Oct 16, 2024
@brw
Copy link
Member

brw commented Oct 16, 2024

I suppose we can skip trying to load the background if a map doesn't have one in listed the .osu file but honestly failures on reading backgrounds are to be expected so it's not that big of a deal.

And yea don't think we've figured out what causes it to try to open the folder it's being run from yet. No idea where that's coming from. It doesn't really harm anything though

@Paladynee
Copy link
Contributor Author

I suppose we can skip trying to load the background if a map doesn't have one in listed the osu db but honestly failures on reading backgrounds are to be expected so it's not that big of a deal.

And yea don't think we've figured out what causes it to try to request the folder it's being run from yet. No idea where that's coming from. It doesn't really harm anything though

I'm trying to pinpoint the issue and write a solution but I'm having trouble logging stuff to the console, I'm not really an electron or typscript dev, just a javascript dev so can you show me some ropes here?

image

@hrfarmer
Copy link
Collaborator

that code is in the "backend" (the node.js side), so anything you log should show up in the terminal in your ide

@brw
Copy link
Member

brw commented Oct 16, 2024

This part is also code that only runs on the initial import of the osu db I'm pretty sure

@hrfarmer
Copy link
Collaborator

^^, either go into app data and delete the osu-radio folder, or uncomment this line https://github.com/Team-BTMC/osu-radio/blob/master/src/main/main.ts#L20

@hrfarmer hrfarmer removed their assignment Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants