-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subtitles appear twice sometimes #11204
Comments
Hmmm. This is occurring on Piped and Invidious too. |
After debugging on this case, we found out that the decoded subtitle input stream indeed contain duplicate subtitle text. Therefore, this should be a subtitle extractor issue. And the player is totally good for rendering subtitle. |
So should I open the issue elsewhere instead? |
Sorry, I do not know it either. |
This is already open as an issue on the extractor side: TeamNewPipe/NewPipeExtractor#1102 . Not sure if this issue should be closed since it also needs work on the NewPipe side to function after the extractor changes @opusforlife2 . |
I think I'll keep it open here until it's fixed in NewPipe. Even if it depends on something else it's still an issue that occurs in the app. I'll close it once the extractor is updated and is fixed in newpipe. |
Normally, an issue that also needs changes in the extractor is labelled as such and left open. In this case, the extractor itself contains the bug, so NPE users like Piped are also affected. I do not know whether there need to be changes made to the app as well after the extractor is fixed, so I'd keep this open to be safe. |
Checklist
Affected version
0.27.0
Steps to reproduce the bug
Expected behavior
The subtitles display correctly, like on the official youtube app as shown below
Actual behavior
The subtitles' color and tempo is correct, but they appear twice, as shown below
Screenshots/Screen recordings
Screen_Recording_20240623_083520_NewPipe.mp4
Logs
No response
Affected Android/Custom ROM version
Android 14 / Stock rom
Affected device model
Samsung Galaxy A52s 5G
Additional information
No response
The text was updated successfully, but these errors were encountered: