Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate hud init, drone teleport warmup and minigun spin-up sounds. #1352

Open
bartico6 opened this issue Oct 3, 2024 · 1 comment
Open
Labels
Enhancement: feature Fixed in Dev Issue will be closed after next release

Comments

@bartico6
Copy link

bartico6 commented Oct 3, 2024

Describe the feature

Pneumatic armor init, drone pathfinding teleport and minigun spin-up all use the same sound - "HUD_INIT". This raises an issue where resourcepacks attempting to make the minigun sounds less ear piercing (I'm sorry, they just aren't great, particularly minigun shooting loop is extremely jarring) end up making drones sound like miniguns, or miniguns sounding like pressure helmets - these three sounds should be separate, but they aren't:

https://github.com/TeamPneumatic/pnc-repressurized/blob/1.21/src/main/java/me/desht/pneumaticcraft/common/minigun/Minigun.java#L307
https://github.com/TeamPneumatic/pnc-repressurized/blob/1.21/src/main/java/me/desht/pneumaticcraft/common/drone/EntityPathNavigateDrone.java#L156
https://github.com/TeamPneumatic/pnc-repressurized/blob/1.21/src/main/java/me/desht/pneumaticcraft/client/render/pneumatic_armor/HUDHandler.java#L243

Reasons why it should be considered

This will allow players to replace sounds of just minigun, just drone warmup or just helmet without affecting the other two, or customise all three.

Additional details

No response

desht added a commit that referenced this issue Jan 31, 2025
They still all use the same .ogg file, but are now logically separate
sounds, making it possible to replace them separately in a resource pack

#1352
@desht
Copy link
Member

desht commented Jan 31, 2025

There are now three separate logical sound events (added pneumaticcraft:minigun_warmup and pneumaticcraft:teleport_warmup). They still all use the same hud_init.ogg by default, but this allows for better resource pack adjustment.

If you do have any references to good (royalty-free) alternative sounds for the minigun, I might be interested.

@desht desht added Enhancement: feature Fixed in Dev Issue will be closed after next release labels Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement: feature Fixed in Dev Issue will be closed after next release
Projects
None yet
Development

No branches or pull requests

2 participants