You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Pneumatic armor init, drone pathfinding teleport and minigun spin-up all use the same sound - "HUD_INIT". This raises an issue where resourcepacks attempting to make the minigun sounds less ear piercing (I'm sorry, they just aren't great, particularly minigun shooting loop is extremely jarring) end up making drones sound like miniguns, or miniguns sounding like pressure helmets - these three sounds should be separate, but they aren't:
There are now three separate logical sound events (added pneumaticcraft:minigun_warmup and pneumaticcraft:teleport_warmup). They still all use the same hud_init.ogg by default, but this allows for better resource pack adjustment.
If you do have any references to good (royalty-free) alternative sounds for the minigun, I might be interested.
Describe the feature
Pneumatic armor init, drone pathfinding teleport and minigun spin-up all use the same sound - "HUD_INIT". This raises an issue where resourcepacks attempting to make the minigun sounds less ear piercing (I'm sorry, they just aren't great, particularly minigun shooting loop is extremely jarring) end up making drones sound like miniguns, or miniguns sounding like pressure helmets - these three sounds should be separate, but they aren't:
https://github.com/TeamPneumatic/pnc-repressurized/blob/1.21/src/main/java/me/desht/pneumaticcraft/common/minigun/Minigun.java#L307
https://github.com/TeamPneumatic/pnc-repressurized/blob/1.21/src/main/java/me/desht/pneumaticcraft/common/drone/EntityPathNavigateDrone.java#L156
https://github.com/TeamPneumatic/pnc-repressurized/blob/1.21/src/main/java/me/desht/pneumaticcraft/client/render/pneumatic_armor/HUDHandler.java#L243
Reasons why it should be considered
This will allow players to replace sounds of just minigun, just drone warmup or just helmet without affecting the other two, or customise all three.
Additional details
No response
The text was updated successfully, but these errors were encountered: