Minimum revenue before selling

[Fluorz]

In this file : https://github.com/TeamWertarbyte/crypto-trading-bot/blob/development/src/modules/bot/index.ts

You are checking if revenue is more than 0 before selling. We can config a minimum revenue before selling.
Sometimes the bot is selling when he makes 10 cents, but with the bittrex commission we are losing money.

I think it would be wise to sell a share only if the revenue including the commission fees are superior to the configurated minimum_revenue.

What do you think about adding a minimum revenue variable?

[Fluorz]

It will also be a good idea to set in the config the bittrex commission. Like this we are sure to sell when revenue - bittrex_commission > minimun_revenue

[saschb2b]

Good idea! Thanks for the suggestion. @Fluorz Will include that in the next release.

crypto-trading-bot/src/modules/bot/index.ts

Line 151 in 235120a

if (revenue > 0) {

How should we interpret minimun_revenue ?
As an absolute value like 5.50 -> 5$ and 50 cents or percent like 5.50 -> 5.5% of amountToInvest -> 5.5% from 50$ = 2.75$

[Fluorz]

In percent I think : https://bittrexglobal.zendesk.com/hc/en-us/articles/360009625260-What-fees-does-Bittrex-Global-charge-

[saschb2b]

I meant the minimun_revenue parameter not bittrex_commission.
bittrex_commission seems to be just a percentage, yes.

Edit: How to calculate comission:

The fee (commission) charged by Bittrex on each executed trade is calculated by taking the (amount * purchase price * rate) for the given trade

[Fluorz]

minimun_revenue in percent would be great 👍

[Fluorz]

A parameter to never reject and just hold would also be nice.

https://github.com/TeamWertarbyte/crypto-trading-bot/blob/development/src/modules/evaluation/EMAEvaluation.ts

[saschb2b]

A parameter to never reject and just hold would also be nice.

https://github.com/TeamWertarbyte/crypto-trading-bot/blob/development/src/modules/evaluation/EMAEvaluation.ts

Already implemented. See example for BTC and ETH here

crypto-trading-bot/config.json

Line 2 in 235120a

"HODL": ["BTC", "ETH"],

Just add your coins to hodl in that array

Edit: Or do you mean globally?

[Fluorz]

I meant globally

[saschb2b]

Would you mind creating a separate issue for that?

[Fluorz]

#49