Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difference between tmr_description and e.g. tm5_description ? #16

Closed
danielcranston opened this issue Dec 3, 2021 · 3 comments
Closed

Comments

@danielcranston
Copy link

Hello @TechmanRobotIncOwner,

There seems to be some redundancy between tmr_description, and tm5_description / tm12_description. I have some quick questions regarding this:

1: If I want to run the ROS driver against a TM5, which description package should I be using?

The tm5_700_moveit_config uses tm5_description. However, I'm interested in applying the error compensation discussed in #15, and it seems the intended script for that lives in tmr_description which makes assumptions that are not valid for the tm5_description URDF layout (see below).

2: It seems the structure of the URDFs are completely different between the tmr_description and the other description packages.

For instance,

  • joint names:
    • tmr_description: joint_1, joint_2, joint_3, ...
    • tm5_description: shoulder_1_joint, shoulder_2_joint, elbow_joint, ...
  • relative joint position/orientations:
    • The kinematic chain seems to be defined quite differently. See the below image which shows the visual part for the same part of the robot, as defined in tm5_description and tmr_description respectively:

image

3: Can you give some history of why these seemingly overlapping packages exist?

It's currently a little bit confusing to understand what you should focus on and what is potentially old/deprecated code. A short explanation here would help a lot I think!

Thank you for reading!

@TechmanRobotIncOwner
Copy link
Contributor

Hi,

"tmr_description" and "tm5_description" is almost the same, the only difference is URDF coordinate.

We will merge these two in the future.

@danielcranston
Copy link
Author

I noticed the packages are still not merged even though this ticket was closed. Could you give an update on this @TechmanRobotIncOwner ?

@TechmanRobotIncOwner
Copy link
Contributor

Hi, we are going to to upload the new model in these two months.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants