Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tm_driver] merge non-moveit and moveit version. #34

Open
3 tasks
MatthijsBurgh opened this issue Aug 30, 2023 · 0 comments
Open
3 tasks

[tm_driver] merge non-moveit and moveit version. #34

MatthijsBurgh opened this issue Aug 30, 2023 · 0 comments

Comments

@MatthijsBurgh
Copy link

I am a robotics engineer at VBTI Eindhoven, The Netherlands

I suggest you drop the 2 versions of the tm_driver. The follow_joint interface can also be used without moveit. So make it the default. Doesn't matter when that interface is exposed, but not used. It does remove some duplicate code.

ToDo's:

  • Merge the moveit classes into the base class.
  • Drop the moveit naming
  • Drop the moveit check from the CMakeLists

I am happy to help you with this PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MatthijsBurgh