Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

equipment_from_json uses filename #516

Open
RenatoParker opened this issue Oct 3, 2024 · 0 comments
Open

equipment_from_json uses filename #516

RenatoParker opened this issue Oct 3, 2024 · 0 comments

Comments

@RenatoParker
Copy link
Contributor

In the json_io.py, the function equipment_from_json at line 396 is using filename as an argument.

This filename is then passed to the method from_json in the class Amp, defined in the same file at line 193.

This filepath is used to load the file default_edfa_config.json.

This raises two main issues:

  1. While using the function equipment_from_json, a filename must be specified. This does not allow the function to parse JSON data that doesn't come from files.
  2. If a user is using gnpy, the file default_edfa_config.json must be provided.

I suggest defining the default_edfa_config information within the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant