Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tilt values from spreadsheet not converted into network json files #521

Open
kt-simpson opened this issue Jan 9, 2025 · 0 comments
Open

Comments

@kt-simpson
Copy link

Describe the bug
I noticed the tilt values in columns F and L of the Eqpt sheet were not converted into the "net_save_fr_path_requests" and "raw_save_fr_load_common" json files.

To Reproduce
Run transmission_main_example using excel as input with tilt values populated to non 0 values
Result: tilt_target values in resulting json files will be at the default value of 0

Expected behavior
Should populate values from spreadsheet into tilt_target fields

Additional context
I was able to resolve the issue by modifying two lines in convert.py as shown below:
Ln 670 changed 'tilt': 'east_tilt', to -> 'tilt': 'east_tilt_vs_wavelength',
Ln 677 changed 'tilt': 'west_tilt', to -> 'tilt': 'west_tilt_vs_wavelength',

This may not be a proper solution but should hopefully highlight the root cause

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant