You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
I noticed the tilt values in columns F and L of the Eqpt sheet were not converted into the "net_save_fr_path_requests" and "raw_save_fr_load_common" json files.
To Reproduce
Run transmission_main_example using excel as input with tilt values populated to non 0 values
Result: tilt_target values in resulting json files will be at the default value of 0
Expected behavior
Should populate values from spreadsheet into tilt_target fields
Additional context
I was able to resolve the issue by modifying two lines in convert.py as shown below:
Ln 670 changed 'tilt': 'east_tilt', to -> 'tilt': 'east_tilt_vs_wavelength',
Ln 677 changed 'tilt': 'west_tilt', to -> 'tilt': 'west_tilt_vs_wavelength',
This may not be a proper solution but should hopefully highlight the root cause
The text was updated successfully, but these errors were encountered:
Describe the bug
I noticed the tilt values in columns F and L of the Eqpt sheet were not converted into the "net_save_fr_path_requests" and "raw_save_fr_load_common" json files.
To Reproduce
Run transmission_main_example using excel as input with tilt values populated to non 0 values
Result: tilt_target values in resulting json files will be at the default value of 0
Expected behavior
Should populate values from spreadsheet into tilt_target fields
Additional context
I was able to resolve the issue by modifying two lines in convert.py as shown below:
Ln 670 changed 'tilt': 'east_tilt', to -> 'tilt': 'east_tilt_vs_wavelength',
Ln 677 changed 'tilt': 'west_tilt', to -> 'tilt': 'west_tilt_vs_wavelength',
This may not be a proper solution but should hopefully highlight the root cause
The text was updated successfully, but these errors were encountered: