Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[popup] 当NODE_ENV环境变量为'test'时,切换路由时会导致窗口无法关闭 #2749

Closed
xinller opened this issue Aug 30, 2023 · 3 comments
Assignees
Labels
🐞 bug Something isn't working to be published fixed, not be published

Comments

@xinller
Copy link

xinller commented Aug 30, 2023

tdesign-vue 版本

1.5.2

重现链接

https://github.com/Tencent/tdesign-vue/blob/develop/src/popup/container.tsx

重现步骤

打开t-popup时,不进行关闭窗口的操作时,此时切换路由到其他的页面时,该窗口无法关闭

期望结果

destroyed() {
if (typeof process !== 'undefined' && process.env?.NODE_ENV === 'test') return;
this.unmountContent();
},

建议:源码popupt/container.tsx这个文件中去掉这边环节变量判断,不理解为什么加上这个判断,巧了我们业务测试环境正好是test,虽然说可以改,但是不去看源码 ,根本找不到这个问题原因

实际结果

No response

框架版本

No response

浏览器版本

No response

系统版本

No response

Node版本

No response

补充说明

No response

@github-actions
Copy link
Contributor

👋 @xinller,感谢给 TDesign 提出了 issue。
请根据 issue 模版确保背景信息的完善,我们将调查并尽快回复你。

@github-actions
Copy link
Contributor

♥️ 有劳 @chaishi @Red626 @ikeq @honkinglin @Aicmortal @uyarn 尽快确认问题。
确认有效后将下一步计划和可能需要的时间回复给 @xinller

@uyarn uyarn added 🐞 bug Something isn't working to be published fixed, not be published labels Aug 31, 2023
@uyarn uyarn mentioned this issue Sep 5, 2023
16 tasks
@uyarn
Copy link
Collaborator

uyarn commented Sep 6, 2023

fixed in 1.6.5

@uyarn uyarn closed this as completed Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working to be published fixed, not be published
Projects
None yet
Development

No branches or pull requests

5 participants