【研发商店】支持展示版本日志 #1761 #11477
Open
【研发商店】支持展示版本日志 #1761 #11477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kzhou991
requested review from
irwinsun,
mingshewhe,
stubenhuang,
carlyin0801,
royalhuang,
randychen2046 and
tangruotian
as code owners
carlyin0801
reviewed
Feb 20, 2025
|
|
||
| @Operation(summary = "根据组件Code获取组件版本日志") | ||
| @GET | ||
| @Path("/{storeType}/{storeCode}/getVersionLogs/") |
There was a problem hiding this comment.
url定义不符合restful风格：应该是比如：/types/{storeType}/codes/{storeCode}/version/logs/get
| @Parameter(description = "userId", required = true) | ||
| @HeaderParam(AUTH_HEADER_USER_ID) | ||
| userId: String, | ||
| @Parameter(description = "组件ID", required = true) |
| pageSize: Int? | ||
| ): Result<Record3<String, String, LocalDateTime>>? { | ||
| val atom = TAtom.T_ATOM | ||
| val atomVersionLogs = TAtomVersionLog.T_ATOM_VERSION_LOG |
| storeVersionLogDao.getStoreComponentVersionLogs(dslContext, storeCode, storeType.type.toByte()) | ||
|
|
||
| val versionLogInfos = if (storeVersionLogList?.isNotEmpty == true) { | ||
| count = storeVersionLogList.size |
There was a problem hiding this comment.
方法很多参数，使用kotlin的name=value这种写法
carlyin0801
reviewed
Feb 20, 2025
| override fun getStoreComponentVersionLogs( | ||
| dslContext: DSLContext, | ||
| storeCode: String, | ||
| page: Int?, |
There was a problem hiding this comment.
现在确定姚分页，page和pageSize不要考虑可为空的情况
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.