Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract Towers into Towers module #70

Open
jdrueckert opened this issue Nov 13, 2021 · 0 comments
Open

Extract Towers into Towers module #70

jdrueckert opened this issue Nov 13, 2021 · 0 comments
Labels
Good First Issue Good for learners that are new to Terasology Size: M Medium-sized effort likely requiring some research and work in multiple areas Topic: Architecture Requests, Issues and Changes related to software architecture, programming patterns, etc. Type: Refactoring Request for or implementation of pure and automatic refactorings, e.g. renaming, to improve clarity

Comments

@jdrueckert
Copy link
Member

GooeyDefence provides modular structures in-game for the player to defend themselves against the incoming enemy waves.
These towers are a gameplay mechanism that should be ignorant of the gameplay it's used in.
That's why, they should be extracted to the Towers module and only referenced / consumed by GooeyDefence from there. This will allow towers to also be used by other modules / gameplays.

@ahv15 already started this effort in Terasology/Towers#2.
This PR can be built upon to finish the extraction. In addition a PR on GooeyDefence should remove the respective code parts and assets and adjust their usage to target the implementation in Towers.
@jdrueckert jdrueckert added Size: M Medium-sized effort likely requiring some research and work in multiple areas Category: Test/QA Requests, Issues and Changes targeting tests and quality assurance Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Type: Refactoring Request for or implementation of pure and automatic refactorings, e.g. renaming, to improve clarity Topic: Architecture Requests, Issues and Changes related to software architecture, programming patterns, etc. and removed Category: Test/QA Requests, Issues and Changes targeting tests and quality assurance Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness labels Nov 13, 2021
This was referenced Nov 13, 2021
Open
Open
@jdrueckert jdrueckert added the Good First Issue Good for learners that are new to Terasology label Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Good for learners that are new to Terasology Size: M Medium-sized effort likely requiring some research and work in multiple areas Topic: Architecture Requests, Issues and Changes related to software architecture, programming patterns, etc. Type: Refactoring Request for or implementation of pure and automatic refactorings, e.g. renaming, to improve clarity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jdrueckert